Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Error when scraping performer with duplicate alias #4596

Closed
Maista6969 opened this issue Feb 19, 2024 · 2 comments · Fixed by #4801 or #4820
Closed

[Bug Report] Error when scraping performer with duplicate alias #4596

Maista6969 opened this issue Feb 19, 2024 · 2 comments · Fixed by #4801 or #4820
Labels
bug report Bug reports that are not yet verified

Comments

@Maista6969
Copy link
Sponsor Contributor

Maista6969 commented Feb 19, 2024

Describe the bug
A user on Discord reported an issue when scraping a performer from PMVStash and getting an error message about duplicate aliases. After going through their performers and aliases to make sure they didn't have a local duplicate we narrowed it down to that particular performer having duplicate aliases on the stash-box itself: MyCherryCrush and Mycherrycrush

I do not have an account on PMVStash and I wasn't able to find a performer on StashDB with a duplicate alias, but over on FansDB Brandi Braids currently has the same kind of duplicate alias: BrandiBraids and brandibraids

edit: Brandi Braids has had her duplicate alias removed

To Reproduce
I believe the original issue occurred when scraping a performer as part of a scene, but it also occurs when you try to add the performer directly:

  1. Go to Performers page
  2. Switch to Tagger view and configure it to use FansDB as the source
  3. Click "Batch Add Performers"
  4. Search for "Brandi Braids" and select the only performer that comes up

No performer is created and no error is displayed, but the logs output Failed to create performer Brandi Braids: performer contains duplicate alias 'brandibraids'

Expected behavior
Just like creating a performer who has an alias that's the same as their own name, I expect the duplicate alias to be dropped and the performer to be created. This was fixed in #4443

Stash Version: (from Settings -> About):
v0.24.3-46-g6fb1c41a

@Maista6969 Maista6969 added the bug report Bug reports that are not yet verified label Feb 19, 2024
@BugGeeker
Copy link
Contributor

I'm a Chinese, and sorry about my english.
Performers in my stash is named to Japanese or Chinese, just like 三上悠亜 or 三上悠亚, I can find 'Yua Mikami' on stashdb,and '三上悠亚' is an alise on stashdb, when I save the scrape result, it will be failed.
Why not automatic remove the duplicate alise when using 'tagger'?
image

@Maista6969
Copy link
Sponsor Contributor Author

This still happens on the latest develop build, after #4801

Go to Performer Tagger view, select Batch Add Performers with StashDB as the source and fill in "AK Gingersnaps" and you'll get this error message in the logs:

ERRO[2024-05-03 14:50:47] Failed to create performer AK Gingersnaps: performer contains duplicate alias 'AKGingersnaps'

She has the alias "AKGINGERSNAPS" as well as "AKGingersnaps"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug reports that are not yet verified
Projects
Status: Done
3 participants