Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Play random button to sceneplayer #557

Closed
matakapo opened this issue May 19, 2020 · 7 comments · Fixed by #1214
Closed

Add Play random button to sceneplayer #557

matakapo opened this issue May 19, 2020 · 7 comments · Fixed by #1214
Labels
bounty This issue has a bounty on it in the OpenCollective feature Pull requests that add a new feature

Comments

@matakapo
Copy link

add a play random button in the sceneplayer to change the scene randomly without having to come back to navigate on scene or scene marker

@bnkai bnkai added the feature Pull requests that add a new feature label May 21, 2020
@velzy00
Copy link

velzy00 commented Jun 15, 2020

I like this idea a lot. I'd also like the option of a play random button on the main scenes page instead of the currently slightly buried menu option.

@silembir
Copy link

Bumping this feature. This is something I would really want to see as well.

@WithoutPants
Copy link
Collaborator

Evaluating design of this for a bounty request:

I think this would be best implemented using #309 instead. Navigating a scene from a scene query would include a playlist view in the scene page, allowing navigation between scenes from the query (including shuffling).

Ideally this would be implemented after we shift to videojs, but it should be easy enough to implement using jwplayer. The original query should be stored by the browser, and this will be used to populate the playlist in the page and in jwplayer. The player itself should have a play next button, and the playlist should be visible on the page.

The playlist view should be collapsible. My preference is to have it above the scene player, and to make the sprite viewer collapsible (I don't personally see the use in it at all). However, some may prefer a panel to the side, I think like how Google does it.

Pornhub show it above the video like so:

image

Youtube shows it to the right of the video (we could potentially add it as a tab on the left panel I guess):

image

Implementation details:

  • scene page should have an optional parameter to indicate that playlist should be included.
  • we will want event hooks into jwplayer to detect when a video finished to change the current scene to the next in the playlist.
  • this should be possible to implement without any backend changes.

To give an indication of effort, if I were to tackle this, I'd be looking at 3 days (24 hours). I believe that someone else may already be working on a similar feature however, so there may be prior work already.

@silembir
Copy link

silembir commented Mar 3, 2021

Just to clarify, this is my desired use case for the bounty:
I just want a button that is persistent on the top of Stash (next to the settings icon perhaps) that shuffles my entire library and plays a random video. The playlist shuffle is also useful but I don't really use playlists. The button would ideally be accessible from the main page as well as an individual scene page and also possibly triggered by a hotkey. Currently the only way to play a random scene is the dropdown menu on the main search page and I'm just trying to avoid doing this every time. Is this what you had in mind?

@stashapp stashapp deleted a comment from JuliusDorsey Mar 3, 2021
@WithoutPants
Copy link
Collaborator

I just want a button that is persistent on the top of Stash (next to the settings icon perhaps) that shuffles my entire library and plays a random video.

I'm hesitant to add another button to the navbar for a reasonably niche function. My proposed alternative use case here is that you would click on scenes, set the filter appropriately (in this case, clear filters), and click the Play Random button. This would play a random scene from the current query, populating a playlist with other scenes from the query. The playlist would also be shuffled when clicking the Play Random button, so the following videos would also be randomised. You would click the play next button to play another random video. This means that you would not need to re-navigate back out to the scenes page to play another random video.

The existing Play Random button is more useful than a top-level "play random scene from my library" button, since it limits what will be played to what's in the current filter. There are other similar use-cases to yours where someone might want to play random scenes featuring a specific performer, for example.

Putting the Play Random button in the filter bar instead of in the overflow menu is possible, but I'd want it as an option, since the filter bar is crowded enough.

I'd prefer not to add another "play random" button to the scene player page, since it would be superceded by playlist functionality anyway and would otherwise be a pretty limited function.

@silembir
Copy link

silembir commented Mar 3, 2021

Ah OK, thanks for the clarification. I was just looking for easier access to the next random video. I think that solution meets my desired use case. I'm placing a $25 bounty on this issue or #309 if you think that's more appropriate.

@WithoutPants
Copy link
Collaborator

Confirmed. $25 bounty on this issue.

@WithoutPants WithoutPants added the bounty This issue has a bounty on it in the OpenCollective label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty This issue has a bounty on it in the OpenCollective feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants