Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork Choice: EF test vectors integration #777

Closed
mratsim opened this issue Mar 4, 2020 · 5 comments
Closed

Fork Choice: EF test vectors integration #777

mratsim opened this issue Mar 4, 2020 · 5 comments
Assignees
@mratsim
Labels
consensus

Comments

@mratsim
Copy link
Contributor

mratsim commented Mar 4, 2020

Splitting from #719

Target: March 2020 if released upstream
The original issue will only track our own implementation and own independent sanity checks.
@mratsim mratsim added this to the Mar 2020 milestone Mar 4, 2020
@mratsim mratsim self-assigned this Mar 4, 2020
@mratsim mratsim modified the milestones: Mar 2020, Apr 2020 Apr 1, 2020
@mratsim
Copy link
Contributor Author

mratsim commented Apr 1, 2020

Apr 1 Status: no test vectors from upstream yet so delayed

@mratsim mratsim mentioned this issue Apr 6, 2020
Merged
2 tasks
@mratsim mratsim modified the milestones: Apr 2020, May 2020 May 6, 2020
@mratsim
Copy link
Contributor Author

mratsim commented May 6, 2020

Still WIP upstream ethereum/consensus-spec-tests#17
But we have a much better Fork choice test suite now from #865

@mratsim mratsim modified the milestones: May 2020, June 2020 Jun 5, 2020
@tersec tersec removed this from the June 2020 milestone Jul 8, 2020
@mratsim
Copy link
Contributor Author

mratsim commented Apr 13, 2021

Upstream fork choice tests were introduced in ethereum/consensus-specs#2202

@tersec
Copy link
Contributor

tersec commented Aug 27, 2021

https://github.com/ethereum/consensus-spec-tests/tree/v1.1.0-beta.3/tests/mainnet/phase0/fork_choice
https://github.com/ethereum/consensus-spec-tests/tree/v1.1.0-beta.3/tests/mainnet/altair/fork_choice

@tersec tersec mentioned this issue Sep 10, 2021
Closed
17 tasks
@tersec
Copy link
Contributor

tersec commented Sep 10, 2021

Merge has these too: https://github.com/ethereum/consensus-spec-tests/tree/v1.1.0-beta.3/tests/mainnet/merge/fork_choice

@mratsim mratsim closed this as completed Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mratsim mratsim

Labels
consensus
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tersec @mratsim