Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed websocket connections are retried instantly #320

Open
Menduist opened this issue Nov 25, 2022 · 2 comments
Open

Failed websocket connections are retried instantly #320

Menduist opened this issue Nov 25, 2022 · 2 comments

Comments

@Menduist
Copy link

Menduist commented Nov 25, 2022

Which will probably lead to some nice DDoSes
To test it out, you can for instance specify a wrong PeerId (the thing after /p2p) in packages/status-js/src/consts/peers.ts
It will lead to this:
image

(not sure if it's actually coming from status-web or js-waku)
Some exponential backoff would nice to avoid frying the servers if a significant amount of nodes start to do this 😃

@felicio
Copy link
Collaborator

felicio commented Dec 21, 2022

Notes

  • status-web now fails, reflects ui and stops js-waku with the following c925efb#commitcomment-93540312
  • so only js-waku@^0.30.0 or rather libp2p dialer is causing these uncontrolled retries when offline/unreachable, however this behavior might have been moved to js-waku in its latest version (cc @fryorcraken)

@fryorcraken
Copy link

Thanks, will keep in mind when investigating waku-org/js-waku#751 which may be fix thanks to an auto-dial from libp2p.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants