Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Prometheus for new metrics #50

Open
vpavlin opened this issue Aug 28, 2024 · 0 comments
Open

Consider using Prometheus for new metrics #50

vpavlin opened this issue Aug 28, 2024 · 0 comments

Comments

@vpavlin
Copy link
Member

vpavlin commented Aug 28, 2024

Prometheus is de facto standard in telemetry, so it would make sense to consider using it to collect our metrics on the client side (go-waku/status-go).

It is also possible to "snapshot" or read current values of the metrics - this would mean we can have metrics locally available via /metrics endpoint if we wanted, but also read and process them and push them to telemetry server in telemetry client.

This would be especially useful for metrics that need to be collected on go-waku (or lower) level as we could just record them there to prometheus and then read them in status-go without any crazy abstractions and leaking or passing custom clients around.

Eventually we could/should also consider pushing metrics to Prometheus PushGateway instead of our custom telemetry server implementation, but that is a stretch goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant