From 9335a3fc2d792652d811fdfb0dbc4c1eee39938d Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Thu, 15 Nov 2012 13:38:08 +1100 Subject: [PATCH] scripts-pnmtologo-fix-for-plain-pbm-checkpatch-fixes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ERROR: do not initialise statics to 0 or NULL #24: FILE: scripts/pnmtologo.c:77: +static int is_plain_pbm = 0; WARNING: line over 80 characters #33: FILE: scripts/pnmtologo.c:108: + * between the digits. This is Ok cause we know a PBM can only have a '1' total: 1 errors, 1 warnings, 25 lines checked ./patches/scripts-pnmtologo-fix-for-plain-pbm.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Andreas Bießmann Cc: Geert Uytterhoeven Signed-off-by: Andrew Morton --- scripts/pnmtologo.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/scripts/pnmtologo.c b/scripts/pnmtologo.c index 68bb4efc5af429..ce937970cf9829 100644 --- a/scripts/pnmtologo.c +++ b/scripts/pnmtologo.c @@ -104,9 +104,11 @@ static unsigned int get_number(FILE *fp) val = 0; while (isdigit(c)) { val = 10*val+c-'0'; - /* some PBM are 'broken'; GiMP for example exports a PBM without space - * between the digits. This is Ok cause we know a PBM can only have a '1' - * or a '0' for the digit. */ + /* + * Some PBM are 'broken'; GiMP for example exports a PBM without space + * between the digits. This is OK because we know a PBM can only have a + * '1' or a '0' for the digit. + */ if (is_plain_pbm) break; c = fgetc(fp);