Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved modulePrefix to config/environment.js #1933

Merged
merged 1 commit into from
Sep 8, 2014

Conversation

jayphelps
Copy link
Member

This is what I'm doing in my apps...but I have a modulePrefix that differs from the project name so maybe this isn't what you all intended by the "TODO: loaded via config"

@rwjblue
Copy link
Member

rwjblue commented Sep 8, 2014

LGTM

@jayphelps
Copy link
Member Author

@rwjblue would be great if this could be synced up with the build too some how. i.e. one canonical place to set modulePrefix and the rest of ember-cli "just works". Obviously, if you hard-code your modulePrefix else where, like import something from 'myapp/something' we can't help you there.

rwjblue added a commit that referenced this pull request Sep 8, 2014
Moved modulePrefix to config/environment.js
@rwjblue rwjblue merged commit 23f0951 into ember-cli:master Sep 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants