Refactor: Allow multiple npm packages to be added at once + tests #2245
Conversation
| @return {Promise} | ||
| */ | ||
| Blueprint.prototype.addPackagesToProject = function(packages) { | ||
| var command = 'npm install --save-dev '; |
There was a problem hiding this comment.
should we not use the npm bundled with ember-cli? (or am i missing something
There was a problem hiding this comment.
I only refactored the existing code, I didn't look to see if there was a task we could use instead. I'll re-code after my meeting to take advantage of the task.
There was a problem hiding this comment.
Yes, we probably should use the internal npm task.
There was a problem hiding this comment.
(similar to the bower install method above)
peterchoo
force-pushed
the
addPackagesToProject
branch
from
243b016
to
13a3cf4
Compare
|
Updated the task to use packaged npm, and call with --save-dev. Squashed commits. |
peterchoo
force-pushed
the
addPackagesToProject
branch
from
13a3cf4
to
b241f30
Compare
|
I've un-broken the smoke tests now :) |
| Blueprint.prototype.addPackagesToProject = function(packages) { | ||
| var task = this.taskFor('npm-install'); | ||
| var ui = this.ui; | ||
| var install = (packages.length > 1) ? ' install packages' : 'install package'; |
There was a problem hiding this comment.
The truthy part includes a leading space, but the falsey part does not. Is that intentional?
peterchoo
force-pushed
the
addPackagesToProject
branch
from
b241f30
to
cb7bcbe
Compare
|
nice! |
| @@ -18,8 +18,10 @@ module.exports = Task.extend({ | |||
| var npmOptions = { | |||
| loglevel: options.verbose ? 'verbose' : 'error', | |||
| logstream: this.ui.outputStream, | |||
| color: 'always' | |||
| color: 'always', | |||
| 'save-dev': (options['save-dev']) ? true : false | |||
There was a problem hiding this comment.
'save-dev': !!options['save-dev'] ?
peterchoo
force-pushed
the
addPackagesToProject
branch
from
cb7bcbe
to
b927a02
Compare
Refactor: Allow multiple npm packages to be added at once + tests
|
👍 |
npm equivalent of #2222