Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ember-export-application-global to default app blueprint. #2270

Merged
merged 1 commit into from
Oct 9, 2014
Merged

Add ember-export-application-global to default app blueprint. #2270

merged 1 commit into from
Oct 9, 2014

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Oct 9, 2014

From #2183 (comment):

The addon solves my problem, but it also requires my knowledge of the addon's existence which seems like a lot to ask of new users.

Exactly, I think the cost/benefit trade-off here makes it clear we should include by default

@rwjblue rwjblue mentioned this pull request Oct 9, 2014
Closed
@stefanpenner
Copy link
Contributor

👍

rwjblue added a commit that referenced this pull request Oct 9, 2014
@rwjblue
Merge pull request #2270 from rwjblue/export-global
086d66b 
Add ember-export-application-global to default app blueprint.
@rwjblue rwjblue merged commit 086d66b into ember-cli:master Oct 9, 2014
@rwjblue rwjblue deleted the export-global branch October 9, 2014 13:14
@jayphelps
Copy link
Member

This PR makes me randy.

BEHAVE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwjblue @stefanpenner @jayphelps @abuiles