Automated npm/browserify/cjs loader

[ef4]

This closes #2283.

It extends the ember-cli addon API in two ways:

• I've added a new 'js' type of postprocessTree. This was suggested by @rwjblue and it nicely solves this particular problem, while being generally useful for other addons.
• addons can use app.importWhitelistFilters to register filters that determine which module names should be ignored by the es6 concatenator.

With these extensions, my new ember-browserify addon can do the actual work of finding & packaging npm modules.

Remaining issues before this is ready to merge:

• Get a PR into broccoli-es6-concatenator (ef4/broccoli-es6-concatenator@joliss:master...master)

[stefanpenner]

👍

[stefanpenner]

An earlier idea I had was to pass ignored Modules by reference, which if preserved would allow updating the pojo to be sufficient. Last I looked, it was possible to fix the concatenator to ensure its binding wasn't broken.
Thoughts? This would also mitigate my later concern (although I do not know its magnitude so it may be worrying for no reason)

[ef4]

Mutating shared objects across module boundaries gives me the heeby jeebies.

[stefanpenner]

Awesome, I am excited for this. I left some comments here and on ember-browserify, nothing blocking merely some feedback.

[stefanpenner]

Ya let's avoid the shared state. LGTM :)

[rwjblue]

👍

[stefanpenner]

@ef4 travis appears unhappy

[ef4]

Yeah I think it's because I'm pointing at my es6 concatenator fork still and not a proper version number.

[stefanpenner]

I've opened the appropriate PR on joliss/es6-broccoli-concatenator project joliss/broccoli-es6-concatenator#29

[ef4]

Ok cool, good timing. I just squashed that branch to prepare to making a PR
myself.

On Mon, Nov 17, 2014 at 10:41 PM, Stefan Penner [email protected]
wrote:

I've opened the appropriate PR on joliss/es6-broccoli-concatenator project
joliss/broccoli-es6-concatenator#29
joliss/broccoli-es6-concatenator#29

—
Reply to this email directly or view it on GitHub
#2505 (comment)
.

[stefanpenner]

:)

[stefanpenner]

@ef4 any ideas re: travis failures?

[ef4]

@stefanpenner , yeah we're waiting on a semver-parsible version of broccoli-es6-concatenator that has the requisite changes. Once one is published I will update my PR to point at it.

1) dependencies in package.json are locked down for pre-1.0 versions:
TypeError: Invalid comparator: git://github.com/ef4/broccoli-es6-concatenator
at Comparator.parse (/home/travis/build/stefanpenner/ember-cli/node_modules/semver/semver.js:605:11)

[stefanpenner]

we are still blocked on @joliss review + feedback on the broccoli-es6-concatenator project bumping this to v0.2.0

[jakecraige]

😢 i want this so baddd