-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add broccoli-ember-hbs-template-compiler. Fixes #408 #574
Conversation
#562 should also be updated to import |
@xtian You're right: We probably should use |
Agreed, we should be precompiling all the time. |
@MajorBreakfast Often I need to use |
I would like it if even those test templates got precompiled. @rjackson I know we precompile inline templates in ember proper, should we follow that same approach here? Or should we maybe have a |
@stefanpenner I'm not sure if you deleted your comment or if it got erased by my force push. Do you want me to leave |
@xtian nah, lets encourage only pre-compilation. |
@xtian I'm fine with the runtime only being included in production as a short term solution, a long term solution would be to discourage it entirely, but I suspect that will not be trivial. If you rebase, I'll merge. |
@stefanpenner Rebased |
I'm 👍, but just want to call out the fact that we now need two steps to update Ember versions since we would be using the I am working on updating this plugin (upstream) to accept the path to the compiler as an option. Then we can simply use the |
Add broccoli-ember-hbs-template-compiler. Fixes #408
just confirmed that it works, and it seems to work great :) |
😀 |
No description provided.