Provide EmberApp with registry access. #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,6 +16,7 @@ | |||
| * [ENHANCEMENT] Bring generators in-house via blueprints. [#747](https://github.com/stefanpenner/ember-cli/pull/747) | |||
| * [BUGFIX] Only process applicaiton code with ES3SafeFilter. [#949](https://github.com/stefanpenner/ember-cli/pull/949) | |||
| * [ENHANCEMENT] Separate applicaiton code from vendor code. Generate `/assets/vendor.js` for vendored code. [#949](https://github.com/stefanpenner/ember-cli/pull/949) | |||
| * [ENHANCEMENT] Provide `registry` access to `EmberApp`. [#955](https://github.com/stefanpenner/ember-cli/pull/955) | |||
There was a problem hiding this comment.
You are correct. Updated.
* Allows customizing registry within `Brocfile.js`. * Provides registry with `EmberApp` instance. * Makes each `Plugin` have a `toTree` method. This will allow plugins that take a different signature to work properly (assuming they implement a custom `toTree`). * Provides `name` property that is provided to `EmberApp` to plugin. This allows the plugin to name the generated output file properly.
stefanpenner
added a commit
that referenced
this pull request
Jun 9, 2014
Provide EmberApp with registry access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brocfile.js.EmberAppinstance.Pluginhave atoTreemethod. This will allow plugins that take a different signature to work properly (assuming they implement a customtoTree).nameproperty that is provided toEmberAppto plugin. This allows the plugin to name the generated output file properly.Fixes #954.
Fixes #827.