Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Authentication issues #28

Closed
yelizariev opened this issue Jan 7, 2020 · 2 comments
Closed

Github Authentication issues #28

yelizariev opened this issue Jan 7, 2020 · 2 comments

Comments

@yelizariev
Copy link
Contributor

Version of the Action
v2.x.x

Describe the bug
The current implementation doesn't allow us to push a commit to repo branch in a way that triggers updating Github Pages content.

Potentially related issue is described here: #26 (comment), but let's focus on Github Pages first

To Reproduce

I played with it here: https://github.com/it-projects-llc/shhvshhshhshh-rukovodstvo-polzovatelia/blob/13.0/.github/workflows/rebuild.yml

Additional context
#26 (comment)

@yelizariev
Copy link
Contributor Author

With regards to #26 (comment)

I'm open to change how the authentication works.
Which version do you prefer now?

Version A:

https://${process.env.GITHUB_ACTOR}:${GITHUB_TOKEN}@github.com/${process.env.GITHUB_REPOSITORY}.git
Version B:

https://${GH_PAT:-"x-access-token:$GITHUB_TOKEN"}@github.com/${GITHUB_REPOSITORY}.git

It seems that GITHUB_ACTOR is ignored by Github anyway, so the Version B looks cleaner

@stefanzweifel
Copy link
Owner

Closed as #36 has been merged into the v3 branch. GitHub authentication is now handled by actions/checkout@v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants