SEP-10: Accept challenge transactions through clock drift #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/utils.ts
Outdated
| @@ -639,8 +639,12 @@ export namespace Utils { | |||
| const now = Math.floor(Date.now() / 1000); | |||
| const { minTime, maxTime } = transaction.timeBounds; | |||
|
|
|||
| // give a small grace period for the transaction time to account for clock drift | |||
| const gracePeriod = 60 * 5; | |||
There was a problem hiding this comment.
Could you make this a parameter of the function, and pass the value in from the SEP-10 read function? This function is only used by the SEP-10 code today, but it is rather generic and the 5 minute time is appropriate for SEP-10 but may not be appropriate for other use cases.
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept challenge transactions that are 5 minutes off from their min and max time, to account for client clocks not matching server clocks.