{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":27085821,"defaultBranch":"master","name":"stellar-core","ownerLogin":"stellar","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-11-24T17:11:12.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/7386716?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726874864.0","currentOid":""},"activityList":{"items":[{"before":"b253ee8c29bd6b4e84c52304c916ffeee36d3d7b","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4475-10ee902a7ce21616a2a56eafd5286e94f5e1b447","pushedAt":"2024-09-21T00:40:50.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"10ee902a7ce21616a2a56eafd5286e94f5e1b447","after":"b253ee8c29bd6b4e84c52304c916ffeee36d3d7b","ref":"refs/heads/master","pushedAt":"2024-09-21T00:40:49.000Z","pushType":"merge_queue_merge","commitsCount":7,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Bump to latest end and update contract cost params for V22 (#4475)\n\n# Description\n\n1. Picks up the latest env version.\n2. Bumps the xdr.\n3. Adds new cost types for V22.\n\nI just finished up what Jay had started, so I still need to review the\ncost type changes.\n\n<!---\n\nDescribe what this pull request does, which issue it's resolving\n(usually applicable for code changes).\n\n--->\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Bump to latest end and update contract cost params for V22 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2537522302\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4475\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4475/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4475\">#4475</a>)"}},{"before":null,"after":"b253ee8c29bd6b4e84c52304c916ffeee36d3d7b","ref":"refs/heads/gh-readonly-queue/master/pr-4475-10ee902a7ce21616a2a56eafd5286e94f5e1b447","pushedAt":"2024-09-20T23:27:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Bump to latest end and update contract cost params for V22 (#4475)\n\n# Description\n\n1. Picks up the latest env version.\n2. Bumps the xdr.\n3. Adds new cost types for V22.\n\nI just finished up what Jay had started, so I still need to review the\ncost type changes.\n\n<!---\n\nDescribe what this pull request does, which issue it's resolving\n(usually applicable for code changes).\n\n--->\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Bump to latest end and update contract cost params for V22 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2537522302\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4475\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4475/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4475\">#4475</a>)"}},{"before":"10ee902a7ce21616a2a56eafd5286e94f5e1b447","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4476-3aeac5d744af2d5f287f65e708af939babcb9be2","pushedAt":"2024-09-20T02:08:15.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"3aeac5d744af2d5f287f65e708af939babcb9be2","after":"10ee902a7ce21616a2a56eafd5286e94f5e1b447","ref":"refs/heads/master","pushedAt":"2024-09-20T02:08:14.000Z","pushType":"merge_queue_merge","commitsCount":2,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Added Ubuntu 24.04 clang-format-12 install instructions (#4476)\n\nAdds instructions on installing `clang-format-12` on Ubuntu 24.04.\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Added Ubuntu 24.04 clang-format-12 install instructions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2537620012\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4476\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4476/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4476\">#4476</a>)"}},{"before":null,"after":"10ee902a7ce21616a2a56eafd5286e94f5e1b447","ref":"refs/heads/gh-readonly-queue/master/pr-4476-3aeac5d744af2d5f287f65e708af939babcb9be2","pushedAt":"2024-09-20T01:35:12.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Added Ubuntu 24.04 clang-format-12 install instructions (#4476)\n\nAdds instructions on installing `clang-format-12` on Ubuntu 24.04.\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Added Ubuntu 24.04 clang-format-12 install instructions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2537620012\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4476\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4476/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4476\">#4476</a>)"}},{"before":"3aeac5d744af2d5f287f65e708af939babcb9be2","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4474-61e8d53a50925afc71959481cadfb497f791834c","pushedAt":"2024-09-19T23:09:43.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"61e8d53a50925afc71959481cadfb497f791834c","after":"3aeac5d744af2d5f287f65e708af939babcb9be2","ref":"refs/heads/master","pushedAt":"2024-09-19T23:09:42.000Z","pushType":"merge_queue_merge","commitsCount":3,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"use --all-targets on cargo tree (#4474)\n\nThis is an attempt (very terrible and unfun) to get the new `cargo tree`\ndep-tree commands to be more stable across platforms and invocations.\nUnfortunately it makes them gigantic.","shortMessageHtmlLink":"use --all-targets on cargo tree (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2537430422\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4474\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4474/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4474\">#4474</a>)"}},{"before":null,"after":"3aeac5d744af2d5f287f65e708af939babcb9be2","ref":"refs/heads/gh-readonly-queue/master/pr-4474-61e8d53a50925afc71959481cadfb497f791834c","pushedAt":"2024-09-19T22:33:46.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"use --all-targets on cargo tree (#4474)\n\nThis is an attempt (very terrible and unfun) to get the new `cargo tree`\ndep-tree commands to be more stable across platforms and invocations.\nUnfortunately it makes them gigantic.","shortMessageHtmlLink":"use --all-targets on cargo tree (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2537430422\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4474\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4474/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4474\">#4474</a>)"}},{"before":"61e8d53a50925afc71959481cadfb497f791834c","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4456-92e6ed0fa0307007a9b1c50c8c8da770b6543fa8","pushedAt":"2024-09-19T20:16:09.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"92e6ed0fa0307007a9b1c50c8c8da770b6543fa8","after":"61e8d53a50925afc71959481cadfb497f791834c","ref":"refs/heads/master","pushedAt":"2024-09-19T20:16:08.000Z","pushType":"merge_queue_merge","commitsCount":3,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Multiple rust libraries with submodules (#4456)\n\nThis modifies the approach we use to linking multiple sorobans. The new\napproach builds each soroban separately into its own `rlib` using a\n`--locked` cargo build, followed by manually providing them as\n`--extern` definitions to the top-level rust build of\nlibstellar_core.rlib.\n\nIt is an approach to solving problems of cargo solving/merging/advancing\ndependency versions when doing soroban multi-versioning (a.k.a.\nhttps://github.com/stellar/stellar-core/issues/4278).\n\nThe approach here is deeply indebted to @leighmcculloch -- he both had\nthe initial idea and overcame almost every obstacle I encountered along\nthe way. I am just the automake-wrestling keyboard monkey in this PR.\n\nAdvantages:\n- We get the soroban lockfiles that were tested upstream, no more no\nless.\n- We get to use git submodules to just point directly to the soroban\nsource trees.\n- Cargo treats all the builds separately: each soroban, then\nstellar-core itself. Never merges deps of any of them.\n\nDisadvantages:\n  - Submodules make a lot of people sad\n  - The necessary automake code _definitely_ makes me sad\n- It breaks vscode or any other IDE trying to edit contract.rs (which,\ngranted, is only 500 lines of code)\n\n## Dep-tree checking\n\nThere's some existing machinery in stellar-core that bakes-in the\nCargo.lock file and then compares the dep-tree of each soroban host in\nit to fixed (manually maintained) dep-tree files we generate with the\n`cargo lock tree` cargo-extension.\n\nThis machinery no longer works with this new scheme:\n  - There is no single lockfile anymore\n- The lockfiles in the submodules contain lots of additional deps and\nchurn (dev-deps especially)\n\nSo instead I've decided to redo this task using a _slightly_ weaker\ntool: `cargo tree`, which is built-in to cargo (not `cargo lock tree`).\nThis loses some precision (`cargo tree` only outputs package version\nnumbers, not checksums) but it allows us to specify the features, and\nexclude the dev-deps, of each submodule. Along the way I've changed it\nfrom a dynamic check to a static one: the build just won't succeed if\nthe expected deptrees (checked-in to the stellar-core repo) don't match\nthe actual ones (extracted at build time from the submodules). The\nresulting errors look like this:\n\n```\n--- rust/src/dep-trees/p21-expect.txt\t2024-09-07 20:38:22.056593002 -0700\n+++ ../src/rust/src/dep-trees/p21-actual.txt\t2024-09-07 20:38:11.852700915 -0700\n@@ -5,7 +5,7 @@\n │   ├── curve25519-dalek-derive v0.1.0 (proc-macro)\n │   │   ├── proc-macro2 v1.0.69\n │   │   │   └── unicode-ident v1.0.9\n-│   │   ├── quote v1.0.32\n+│   │   ├── quote v1.0.33\n │   │   │   └── proc-macro2 v1.0.69 (*)\n │   │   └── syn v2.0.39\n │   │       ├── proc-macro2 v1.0.69 (*)\ndep trees differ, please update p21-expect.txt or roll back submodule\n```\n\nI think this is a generally superior developer experience for us,\ndespite the minor loss in precision around dep identities. In practice I\nthink the package version numbers are precise enough.\n\n## Dep-tree differences\n\nIf you take a look at the dep tree being checked in with this change for\nthe p21 host and compare to the dep tree baked into master's current\nlockfile for the `soroban-env-host@21.2.0` package, you will see some\nslight differences: specifically you'll see that this PR _downgrades_\n`smallvec 1.13.2 -> 1.10.0`, `libm 0.2.8 -> 0.2.7` and `wasmparser-nostd\n0.100.2 -> 0.100.1`, and the removal of `ahash`. These downgrades are\nactually a _revert_ of changes that happened recently in\ne967b1883bdd4eecf70bebe5db509138704e119 where I generalized support for\nmultiple versions of soroban and simultaneously brought the p22 env into\ncore: at that point I was forced (by cargo's aggressive version\nunification) to allow those _upgrades_ to the dep-tree of the p21 host,\neven though I kinda didn't want to. I accepted them at the time as\n\"probably unobservable and worth the bet\" but, in fact, the presence of\nsuch unwanted upgrades was one of the motivating factors for _this PR_,\nthat reverts them by downgrading them.\n\nLuckily we have not _released_ anything with those unwanted-upgrades\nyet, so reverting and downgrading them to the exact versions that (a)\nshipped in p21 and (b) are baked into the lockfile of the env git repo\nat the point in history when p21 was released is the right thing to do\nhere. But it was good to check!","shortMessageHtmlLink":"Multiple rust libraries with submodules (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2507027235\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4456\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4456/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4456\">#4456</a>)"}},{"before":null,"after":"61e8d53a50925afc71959481cadfb497f791834c","ref":"refs/heads/gh-readonly-queue/master/pr-4456-92e6ed0fa0307007a9b1c50c8c8da770b6543fa8","pushedAt":"2024-09-19T19:41:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Multiple rust libraries with submodules (#4456)\n\nThis modifies the approach we use to linking multiple sorobans. The new\napproach builds each soroban separately into its own `rlib` using a\n`--locked` cargo build, followed by manually providing them as\n`--extern` definitions to the top-level rust build of\nlibstellar_core.rlib.\n\nIt is an approach to solving problems of cargo solving/merging/advancing\ndependency versions when doing soroban multi-versioning (a.k.a.\nhttps://github.com/stellar/stellar-core/issues/4278).\n\nThe approach here is deeply indebted to @leighmcculloch -- he both had\nthe initial idea and overcame almost every obstacle I encountered along\nthe way. I am just the automake-wrestling keyboard monkey in this PR.\n\nAdvantages:\n- We get the soroban lockfiles that were tested upstream, no more no\nless.\n- We get to use git submodules to just point directly to the soroban\nsource trees.\n- Cargo treats all the builds separately: each soroban, then\nstellar-core itself. Never merges deps of any of them.\n\nDisadvantages:\n  - Submodules make a lot of people sad\n  - The necessary automake code _definitely_ makes me sad\n- It breaks vscode or any other IDE trying to edit contract.rs (which,\ngranted, is only 500 lines of code)\n\n## Dep-tree checking\n\nThere's some existing machinery in stellar-core that bakes-in the\nCargo.lock file and then compares the dep-tree of each soroban host in\nit to fixed (manually maintained) dep-tree files we generate with the\n`cargo lock tree` cargo-extension.\n\nThis machinery no longer works with this new scheme:\n  - There is no single lockfile anymore\n- The lockfiles in the submodules contain lots of additional deps and\nchurn (dev-deps especially)\n\nSo instead I've decided to redo this task using a _slightly_ weaker\ntool: `cargo tree`, which is built-in to cargo (not `cargo lock tree`).\nThis loses some precision (`cargo tree` only outputs package version\nnumbers, not checksums) but it allows us to specify the features, and\nexclude the dev-deps, of each submodule. Along the way I've changed it\nfrom a dynamic check to a static one: the build just won't succeed if\nthe expected deptrees (checked-in to the stellar-core repo) don't match\nthe actual ones (extracted at build time from the submodules). The\nresulting errors look like this:\n\n```\n--- rust/src/dep-trees/p21-expect.txt\t2024-09-07 20:38:22.056593002 -0700\n+++ ../src/rust/src/dep-trees/p21-actual.txt\t2024-09-07 20:38:11.852700915 -0700\n@@ -5,7 +5,7 @@\n │   ├── curve25519-dalek-derive v0.1.0 (proc-macro)\n │   │   ├── proc-macro2 v1.0.69\n │   │   │   └── unicode-ident v1.0.9\n-│   │   ├── quote v1.0.32\n+│   │   ├── quote v1.0.33\n │   │   │   └── proc-macro2 v1.0.69 (*)\n │   │   └── syn v2.0.39\n │   │       ├── proc-macro2 v1.0.69 (*)\ndep trees differ, please update p21-expect.txt or roll back submodule\n```\n\nI think this is a generally superior developer experience for us,\ndespite the minor loss in precision around dep identities. In practice I\nthink the package version numbers are precise enough.\n\n## Dep-tree differences\n\nIf you take a look at the dep tree being checked in with this change for\nthe p21 host and compare to the dep tree baked into master's current\nlockfile for the `soroban-env-host@21.2.0` package, you will see some\nslight differences: specifically you'll see that this PR _downgrades_\n`smallvec 1.13.2 -> 1.10.0`, `libm 0.2.8 -> 0.2.7` and `wasmparser-nostd\n0.100.2 -> 0.100.1`, and the removal of `ahash`. These downgrades are\nactually a _revert_ of changes that happened recently in\ne967b1883bdd4eecf70bebe5db509138704e119 where I generalized support for\nmultiple versions of soroban and simultaneously brought the p22 env into\ncore: at that point I was forced (by cargo's aggressive version\nunification) to allow those _upgrades_ to the dep-tree of the p21 host,\neven though I kinda didn't want to. I accepted them at the time as\n\"probably unobservable and worth the bet\" but, in fact, the presence of\nsuch unwanted upgrades was one of the motivating factors for _this PR_,\nthat reverts them by downgrading them.\n\nLuckily we have not _released_ anything with those unwanted-upgrades\nyet, so reverting and downgrading them to the exact versions that (a)\nshipped in p21 and (b) are baked into the lockfile of the env git repo\nat the point in history when p21 was released is the right thing to do\nhere. But it was good to check!","shortMessageHtmlLink":"Multiple rust libraries with submodules (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2507027235\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4456\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4456/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4456\">#4456</a>)"}},{"before":"92e6ed0fa0307007a9b1c50c8c8da770b6543fa8","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4464-3c3fd65850652f5d9b1f462565d433bb15a3f33e","pushedAt":"2024-09-19T00:27:02.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"3c3fd65850652f5d9b1f462565d433bb15a3f33e","after":"92e6ed0fa0307007a9b1c50c8c8da770b6543fa8","ref":"refs/heads/master","pushedAt":"2024-09-19T00:27:00.000Z","pushType":"merge_queue_merge","commitsCount":3,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Update Core to protocol 22. (#4464)\n\n# Description\n\nUpdate Core to protocol 22 and ungate the tests that rely on the new\nprotocol.\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Update Core to protocol 22. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2520840889\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4464\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4464/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4464\">#4464</a>)"}},{"before":"3c3fd65850652f5d9b1f462565d433bb15a3f33e","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4472-bfd1cc2951d6d4a399b4513e5f6497dedf442eaa","pushedAt":"2024-09-18T23:52:25.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":null,"after":"92e6ed0fa0307007a9b1c50c8c8da770b6543fa8","ref":"refs/heads/gh-readonly-queue/master/pr-4464-3c3fd65850652f5d9b1f462565d433bb15a3f33e","pushedAt":"2024-09-18T23:52:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Update Core to protocol 22. (#4464)\n\n# Description\n\nUpdate Core to protocol 22 and ungate the tests that rely on the new\nprotocol.\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Update Core to protocol 22. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2520840889\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4464\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4464/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4464\">#4464</a>)"}},{"before":"bfd1cc2951d6d4a399b4513e5f6497dedf442eaa","after":"3c3fd65850652f5d9b1f462565d433bb15a3f33e","ref":"refs/heads/master","pushedAt":"2024-09-18T23:52:24.000Z","pushType":"merge_queue_merge","commitsCount":2,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Fix compiler error when tests are disabled (#4472)\n\n# Checklist\n- [x] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [x] Rebased on top of master (no merge commits)\n- [x] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [x] Compiles\n- [x] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Fix compiler error when tests are disabled (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2534827684\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4472\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4472/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4472\">#4472</a>)"}},{"before":null,"after":"3c3fd65850652f5d9b1f462565d433bb15a3f33e","ref":"refs/heads/gh-readonly-queue/master/pr-4472-bfd1cc2951d6d4a399b4513e5f6497dedf442eaa","pushedAt":"2024-09-18T23:19:14.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Fix compiler error when tests are disabled (#4472)\n\n# Checklist\n- [x] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [x] Rebased on top of master (no merge commits)\n- [x] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [x] Compiles\n- [x] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Fix compiler error when tests are disabled (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2534827684\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4472\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4472/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4472\">#4472</a>)"}},{"before":"bfd1cc2951d6d4a399b4513e5f6497dedf442eaa","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4439-7fce6cb9c19a88dbe6c559346b7a3a886cc590e7","pushedAt":"2024-09-18T05:53:44.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"7fce6cb9c19a88dbe6c559346b7a3a886cc590e7","after":"bfd1cc2951d6d4a399b4513e5f6497dedf442eaa","ref":"refs/heads/master","pushedAt":"2024-09-18T05:53:43.000Z","pushType":"merge_queue_merge","commitsCount":4,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Add SOROBAN_TEST_EXTRA_PROTOCOL for side-by-side testing (#4439)\n\nThis implements an idea @MonsieurNicolas proposed recently: now that we\nhave fairly easy \"by version number\" selection among different soroban\nhosts, we can run any given transaction _twice_ during offline replay to\nsee (a) whether it produces the same side effects and (b) whether it\nperforms the same or different.\n\nIt works during any tx application -- offilne catchup or online\nexecution -- you just set `SOROBAN_TEST_EXTRA_PROTOCOL=22` (say) and\nwhile replaying a p21 tx it'll also execute it on p22 and report a\nsummary of both txs side by side. You may also need to set\n`SOROBAN_TEST_CPU_BUDGET_FACTOR=2` or so to give a bit more budget\nwiggle room to txs that might have higher execution costs.","shortMessageHtmlLink":"Add SOROBAN_TEST_EXTRA_PROTOCOL for side-by-side testing (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2484144783\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4439\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4439/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4439\">#4439</a>)"}},{"before":null,"after":"bfd1cc2951d6d4a399b4513e5f6497dedf442eaa","ref":"refs/heads/gh-readonly-queue/master/pr-4439-7fce6cb9c19a88dbe6c559346b7a3a886cc590e7","pushedAt":"2024-09-18T04:48:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Add SOROBAN_TEST_EXTRA_PROTOCOL for side-by-side testing (#4439)\n\nThis implements an idea @MonsieurNicolas proposed recently: now that we\nhave fairly easy \"by version number\" selection among different soroban\nhosts, we can run any given transaction _twice_ during offline replay to\nsee (a) whether it produces the same side effects and (b) whether it\nperforms the same or different.\n\nIt works during any tx application -- offilne catchup or online\nexecution -- you just set `SOROBAN_TEST_EXTRA_PROTOCOL=22` (say) and\nwhile replaying a p21 tx it'll also execute it on p22 and report a\nsummary of both txs side by side. You may also need to set\n`SOROBAN_TEST_CPU_BUDGET_FACTOR=2` or so to give a bit more budget\nwiggle room to txs that might have higher execution costs.","shortMessageHtmlLink":"Add SOROBAN_TEST_EXTRA_PROTOCOL for side-by-side testing (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2484144783\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4439\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4439/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4439\">#4439</a>)"}},{"before":"7fce6cb9c19a88dbe6c559346b7a3a886cc590e7","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4468-7712e4a91bf828fe1408f793f79a99d7ad2310be","pushedAt":"2024-09-18T01:51:08.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"7712e4a91bf828fe1408f793f79a99d7ad2310be","after":"7fce6cb9c19a88dbe6c559346b7a3a886cc590e7","ref":"refs/heads/master","pushedAt":"2024-09-18T01:51:08.000Z","pushType":"merge_queue_merge","commitsCount":2,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"tx queue update (#4468)\n\n# Description\n\nUpdate tx queue logic\n\n<!---\n\nDescribe what this pull request does, which issue it's resolving\n(usually applicable for code changes).\n\n--->\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"tx queue update (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2532086828\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4468\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4468/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4468\">#4468</a>)"}},{"before":"7712e4a91bf828fe1408f793f79a99d7ad2310be","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4402-df572696d3c251b769ffaa3fe7086df2b5230923","pushedAt":"2024-09-18T00:48:51.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":null,"after":"7fce6cb9c19a88dbe6c559346b7a3a886cc590e7","ref":"refs/heads/gh-readonly-queue/master/pr-4468-7712e4a91bf828fe1408f793f79a99d7ad2310be","pushedAt":"2024-09-18T00:48:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"tx queue update (#4468)\n\n# Description\n\nUpdate tx queue logic\n\n<!---\n\nDescribe what this pull request does, which issue it's resolving\n(usually applicable for code changes).\n\n--->\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"tx queue update (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2532086828\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4468\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4468/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4468\">#4468</a>)"}},{"before":"df572696d3c251b769ffaa3fe7086df2b5230923","after":"7712e4a91bf828fe1408f793f79a99d7ad2310be","ref":"refs/heads/master","pushedAt":"2024-09-18T00:48:50.000Z","pushType":"merge_queue_merge","commitsCount":7,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Apply time benchmarking (#4402)\n\n# Description\n\nResolves https://github.com/stellar/stellar-core/issues/4391/.\n\n<!---\n\nDescribe what this pull request does, which issue it's resolving\n(usually applicable for code changes).\n\n--->\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Apply time benchmarking (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2438380829\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4402\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4402/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4402\">#4402</a>)"}},{"before":null,"after":"7712e4a91bf828fe1408f793f79a99d7ad2310be","ref":"refs/heads/gh-readonly-queue/master/pr-4402-df572696d3c251b769ffaa3fe7086df2b5230923","pushedAt":"2024-09-17T23:45:05.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Apply time benchmarking (#4402)\n\n# Description\n\nResolves https://github.com/stellar/stellar-core/issues/4391/.\n\n<!---\n\nDescribe what this pull request does, which issue it's resolving\n(usually applicable for code changes).\n\n--->\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Apply time benchmarking (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2438380829\" data-permission-text=\"Title is private\" data-url=\"https://github.com/stellar/stellar-core/issues/4402\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/stellar/stellar-core/pull/4402/hovercard\" href=\"https://github.com/stellar/stellar-core/pull/4402\">#4402</a>)"}},{"before":"df572696d3c251b769ffaa3fe7086df2b5230923","after":null,"ref":"refs/heads/gh-readonly-queue/master/pr-4467-d2e025effc5be854cf98540ef1b887d9e75f5094","pushedAt":"2024-09-17T21:02:49.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"d2e025effc5be854cf98540ef1b887d9e75f5094","after":"df572696d3c251b769ffaa3fe7086df2b5230923","ref":"refs/heads/master","pushedAt":"2024-09-17T21:02:48.000Z","pushType":"merge_queue_merge","commitsCount":2,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Add 'phase 1' testnet settings that we need to apply after every reset. (#4467)\n\n# Description\n\nAdd 'phase 1' testnet settings that we need to apply after every reset.\n\nFull settings don't fit into the initial contract data size limit.\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Add 'phase 1' testnet settings that we need to apply after every rese…"}},{"before":null,"after":"df572696d3c251b769ffaa3fe7086df2b5230923","ref":"refs/heads/gh-readonly-queue/master/pr-4467-d2e025effc5be854cf98540ef1b887d9e75f5094","pushedAt":"2024-09-17T19:50:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Add 'phase 1' testnet settings that we need to apply after every reset. (#4467)\n\n# Description\n\nAdd 'phase 1' testnet settings that we need to apply after every reset.\n\nFull settings don't fit into the initial contract data size limit.\n\n# Checklist\n- [ ] Reviewed the\n[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)\ndocument\n- [ ] Rebased on top of master (no merge commits)\n- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio\nextension)\n- [ ] Compiles\n- [ ] Ran all tests\n- [ ] If change impacts performance, include supporting evidence per the\n[performance\ndocument](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)","shortMessageHtmlLink":"Add 'phase 1' testnet settings that we need to apply after every rese…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yMVQwMDo0MDo1MC4wMDAwMDBazwAAAAS8donj","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yMVQwMDo0MDo1MC4wMDAwMDBazwAAAAS8donj","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xN1QxOTo1MDowNC4wMDAwMDBazwAAAAS47mm8"}},"title":"Activity · stellar/stellar-core"}