Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

completed_at in SEP24 is inconsistently defined from SEP6 and SEP31 #1184

Closed
lijamie98 opened this issue Apr 29, 2022 · 0 comments · Fixed by #1185
Closed

completed_at in SEP24 is inconsistently defined from SEP6 and SEP31 #1184

lijamie98 opened this issue Apr 29, 2022 · 0 comments · Fixed by #1185
Assignees
@lijamie98

Comments

@lijamie98
Copy link
Contributor

lijamie98 commented Apr 29, 2022 •
edited
Loading

completed_at was defined as Optional fields in SEP-6 and SEP-31. However, the field is defined as Assigned null for in-progress transactions. in SEP-24.

Suggest to make the field consistent among all protocols.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lijamie98 lijamie98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SEP-24: Change completed_at field to optional stellar/stellar-protocol
1 participant
@lijamie98