SEP-24: make account deposit request parameter optional
#1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1342
Makes the
accountparameter for thePOST /transactions/deposit/interactiverequest optional to match thePOST /transactions/withdraw/interactiverequest.SEP-24 originally did not require SEP-10, and because of that, required that the client specify the destination account of the payment via the deposit request body. When we introduced SEP-10, we should have also updated the SEP to have anchors default to using the authenticated account as the destination.
This change will make the deposit request's
accountparameter definition consistent with the withdraw request's account parameter, which is also optional.This is technically a breaking change for anchors that assume the
accountfield will always be present, although in practice this is easy for wallets to work around.