Add SEP-38 support to SEP-24 #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeUrban
reviewed
Jun 9, 2023
There was a problem hiding this comment.
This is a good start!
I don't see any changes to GET /info though, we wanted to make changes there right?
I think the only other change requested is to explore adding a parameter for pre-populating the off-chain asset, although its not strictly necessary since we have a UI.
JakeUrban
reviewed
Jun 11, 2023
lijamie98
reviewed
Jun 13, 2023
lijamie98
reviewed
Jun 13, 2023
CassioMG
reviewed
Jun 14, 2023
CassioMG
reviewed
Jun 14, 2023
CassioMG
reviewed
Jun 14, 2023
CassioMG
reviewed
Jun 14, 2023
CassioMG
reviewed
Jun 15, 2023
JakeUrban
previously approved these changes
Jul 17, 2023
# Conflicts: # ecosystem/sep-0024.md
JakeUrban
previously approved these changes
Jul 17, 2023
ecosystem/sep-0024.md
Outdated
Comment on lines
975
to
976
| by `SEP-38 POST /quote` and `SEP-38 POST /prices` API. If set to yes, anchor must support `quote_id` parameter in | ||
| interactive endpoints and transaction response body. | |
ecosystem/sep-0024.md
Outdated
|
|
||
| ## Fee | ||
|
|
||
| ### This endpoint is deprecated. The [SEP-38] `GET /price` endpoint should be used to fetch fees instead. |
There was a problem hiding this comment.
I would use **bold** markdown here rather than a header.
JakeUrban
approved these changes
Jul 17, 2023
This was referenced Sep 27, 2023
JiahuiWho
added a commit
to stellar/java-stellar-anchor-sdk
that referenced
this pull request
Nov 27, 2023
### Description If `quote_id` is provided upon receiving the sep24 request, fetch quote details and populate it into sep24txn object Left out the quote validation since it's specified in doc > When `quote_id` is set, `asset_code`, `source_asset` and `amount` must be validated by the anchor, if present. In case of a conflict with the ones used to create the [SEP-38] quote, this request should be rejected with a `400`. ### Context Add `quote_id` and `source_asset_id` to sep24 txn so that quotes can be displayed to users while initiate deposit/withdraw sep24 transaction ### Testing - `./gradlew test` ### Documentation Updated in stellar/stellar-protocol#1358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Currently, there is no way for a wallet to get a quote from the anchor in a standardized way. Anchors may have in-house endpoints for the wallet, however, wallet would need to implement a new set of API for each anchor it integrates with.
What's more, current fee endpoint is not flexible enough, and doesn't offer complex functionality SEP-38 fee (part of the quote object body) has.
Having a quote and fees before proceeding to the interactive screen is very important for the user experience, as without it, user would not be able to know this information before initiating a transaction.
Proposal
This proposal is aimed to solve this problem. We add integration of the existing SEP-38 endpoint with the SEP-24. The wallet may now use the existing SEP-38 endpoints implemented by the anchor to query a quote.
Later, wallet may use the quote id (for the firm quote) to exchange the asset on agreed rates.
Changelog summary
Add support for the SEP-38 API. Add optional
quote_idparameter topost /transactions/deposit/interactiveand
POST /transactions/deposit/interactiverequests. Addquote_idto the transaction object schema.Use cases
/priceand/pricesendpointsBackward compatibility
This proposal is fully backward compatible