Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-9 : Add mobile_number_format field to Natural Person Fields #1481

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

CassioMG
Copy link
Contributor

@CassioMG CassioMG commented Apr 22, 2024

Depending on the integration (e.g the Stellar Disbursement Platform) parts may want to hash the mobile number to increase security during the data sharing between wallets and Anchors.

@CassioMG CassioMG changed the title SEP-9 : Add 'mobile_number_hash' field to Natural Person Fields SEP-9 : Add mobile_number_hash field to Natural Person Fields Apr 22, 2024
@CassioMG CassioMG marked this pull request as ready for review April 22, 2024 18:37
reecexlm
reecexlm previously approved these changes Apr 22, 2024
@reecexlm reecexlm dismissed their stale review April 22, 2024 18:52

need additional review

@Ifropc
Copy link
Contributor

Ifropc commented Apr 22, 2024

@CassioMG maybe adding a mobile_number format would be a more flexible approach? You can pass the hash in mobile_number field but set "hash" in the mobile_number_format field to indicate the hash format

@CassioMG
Copy link
Contributor Author

@CassioMG maybe adding a mobile_number format would be a more flexible approach? You can pass the hash in mobile_number field but set "hash" in the mobile_number_format field to indicate the hash format

@Ifropc thanks for the suggestion. What would be the possible values for mobile_number_format in this case?

@Ifropc
Copy link
Contributor

Ifropc commented Apr 22, 2024

@CassioMG
I'd suggest it to be a usual String type with suggested values E164 or E.164 ("Standard" format which we used to see, e.g. +14155552671 see wiki), hash (you should add a small comment about this hash format) and I think that's it for now. If this value is not specified, receiver should assume it's in E164 format

@CassioMG
Copy link
Contributor Author

@CassioMG I'd suggest it to be a usual String type with suggested values E164 or E.164 ("Standard" format which we used to see, e.g. +14155552671 see wiki), hash (you should add a small comment about this hash format) and I think that's it for now. If this value is not specified, receiver should assume it's in E164 format

@Ifropc I like this idea. I've updated the PR to reflect it. I left a etc... on the field description to add more flexibility to it so sender and receiver could explore this field with different formats other than the suggested ones. Let me know what you think

@CassioMG CassioMG changed the title SEP-9 : Add mobile_number_hash field to Natural Person Fields SEP-9 : Add mobile_number_format field to Natural Person Fields Apr 23, 2024
Copy link
Contributor

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ifropc Ifropc merged commit 52cefb7 into stellar:master Apr 26, 2024
3 checks passed
@CassioMG CassioMG deleted the patch-5 branch April 26, 2024 17:45
@gre3n3yes34
Copy link

How does the system connect to the future clients I have and will accumulate over time. I'm starting back up an Insurance company .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants