Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-24: Make amount_out optional in transaction responses #1520

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

philipliu
Copy link
Contributor

@philipliu philipliu commented Aug 7, 2024

SEP-24 supports indicative quotes. amount_out should not be set before users transfer funds.

@philipliu philipliu marked this pull request as ready for review August 7, 2024 19:37
JakeUrban
JakeUrban previously approved these changes Aug 7, 2024
Copy link
Contributor

@JakeUrban JakeUrban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some additional context in the field description may be useful.

ecosystem/sep-0024.md Outdated Show resolved Hide resolved
ecosystem/sep-0024.md Outdated Show resolved Hide resolved
ecosystem/sep-0024.md Show resolved Hide resolved
ecosystem/sep-0024.md Show resolved Hide resolved
@philipliu philipliu merged commit 44672f5 into stellar:master Aug 14, 2024
3 checks passed
@philipliu philipliu deleted the sep-24-indicative branch August 14, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants