Skip to content
This repository has been archived by the owner on Nov 17, 2021. It is now read-only.

Figures pdf list item should be sibling of article pdf list item #200

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Figures pdf list item should be sibling of article pdf list item #200

merged 1 commit into from
Jul 2, 2020

Conversation

nlisgo
Copy link
Collaborator

@nlisgo nlisgo commented Jun 25, 2020

No description provided.

@nlisgo nlisgo requested a review from discodavey June 25, 2020 08:51
@codecov-commenter
Copy link

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files           9        9           
  Lines         255      255           
  Branches       66       66           
=======================================
  Hits          224      224           
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bbc7d7...49b8c30. Read the comment docs.

@nlisgo nlisgo mentioned this pull request Jun 25, 2020
Merged
@nlisgo
Copy link
Collaborator Author

nlisgo commented Jun 25, 2020

@alex-ketch what does this failed run indicate?

@nlisgo nlisgo requested a review from alex-ketch June 25, 2020 13:23
alex-ketch
alex-ketch approved these changes Jun 25, 2020
View reviewed changes
Copy link
Collaborator

@alex-ketch alex-ketch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nlisgo the project automation task failure for assigning a GitHub Project can be ignored, seems a change in the GitHub action caused it to break. I will investigate and fix, but should be of no consequence to the code.

@nlisgo
Copy link
Collaborator Author

nlisgo commented Jul 1, 2020

@alex-ketch are you willing to merge this in now?

@nlisgo nlisgo requested a review from alex-ketch July 1, 2020 09:09
@nlisgo nlisgo mentioned this pull request Jul 1, 2020
Merged
@alex-ketch
Copy link
Collaborator

Hi @nlisgo, please feel free to merge eLife theme related changes such as this yourself :)
If there are changes which could impact other themes, or the overall project, then please do wait for a PR review.
Thanks!

@alex-ketch alex-ketch merged commit b7b7167 into stencila:master Jul 2, 2020
stencila-ci added a commit that referenced this pull request Jul 2, 2020
@stencila-ci
chore(release): 2.10.4 [skip ci]
0b56e06 
## [2.10.4](v2.10.3...v2.10.4) (2020-07-02)

### Bug Fixes

* **eLife:** Figures pdf list item should be sibling of article pdf list item ([b7b7167](b7b7167)), closes [#200](#200)
@stencila-ci
Copy link
Collaborator

🎉 This PR is included in version 2.10.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@discodavey discodavey discodavey approved these changes

@alex-ketch alex-ketch Awaiting requested review from alex-ketch

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nlisgo @codecov-commenter @alex-ketch @stencila-ci @discodavey