Skip to content
This repository has been archived by the owner on Nov 17, 2021. It is now read-only.

fix(eLife): update unit tests to support new reference format #293

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

discodavey
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 10, 2021

Codecov Report

Merging #293 (e79e5d6) into master (033cbf5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #293   +/-   ##
=======================================
  Coverage   90.87%   90.87%           
=======================================
  Files          10       10           
  Lines         252      252           
  Branches       66       66           
=======================================
  Hits          229      229           
  Misses         23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033cbf5...e79e5d6. Read the comment docs.

@discodavey discodavey changed the title Refactor to get errors to show fix: Refactor to get errors to show Feb 10, 2021
Copy link
Collaborator

@NuclearRedeye NuclearRedeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, once addressed it should in my opinion be OK to merge. You might want to make the title more meaningful also, e.g. fix(eLife): update unit tests to support new reference format

@discodavey
Copy link
Collaborator Author

Yes, I should have done that

@discodavey discodavey changed the title fix: Refactor to get errors to show fix(eLife): Refactor to get errors to show Feb 10, 2021
@discodavey discodavey changed the title fix(eLife): Refactor to get errors to show fix(eLife): update unit tests to support new reference format Feb 10, 2021
@alex-ketch alex-ketch merged commit edae444 into stencila:master Feb 10, 2021
@discodavey discodavey deleted the reference-formatting branch February 10, 2021 14:42
stencila-ci added a commit that referenced this pull request Feb 10, 2021
## [2.20.14](v2.20.13...v2.20.14) (2021-02-10)

### Bug Fixes

* **eLife:** update unit tests to support new reference format ([#293](#293)) ([edae444](edae444))
@stencila-ci
Copy link
Collaborator

🎉 This PR is included in version 2.20.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants