This repository has been archived by the owner on Nov 17, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Reorganize shared folder and update guide for authors #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some discussion on the pros and cons of alternative approaches, @alex-ketch and I agreed that it would be best not to have |
See last bullet point in #25 (comment)
…ents for document nodes
nokome
force-pushed
the
shared-revamp
branch
from
February 19, 2020 07:33
57e1d0b
to
e73d853
Compare
… executable nodes
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to finally close #25 with a reorganization of the
src/shared
repo and some guidelines and examples for theme authors. It will add two new themesbootstrap
: an example of bootstrapping a theme from an existing stylesheet (as withelife
theme)zombie
: an example of a theme that relies heavily on the styles defined inshared
(cf.skeleton
which does not at all)@davidcmoulton @alex-ketch This is still WIP but I wanted to make you aware of it. Especially the use of the
shared/js/dom
functions to modify the DOM as needed to apply an existing stylesheet: https://github.com/stencila/thema/pull/52/files#diff-4b8a23a18d6432149ae65d5eca083717R1The to do list for this PR:
index.{js|ts}
and functionsnpm run lint:styles
to passsrc/shared/styles/types
and use them inzombie