Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's no license text in license.md #47

Open
vmbrasseur opened this issue Jul 29, 2014 · 2 comments
Open

There's no license text in license.md #47

vmbrasseur opened this issue Jul 29, 2014 · 2 comments
Labels
Milestone

Comments

@vmbrasseur
Copy link
Member

Really? Just mention the license w/o actually including it in the file?

Bad form. Fix this.

@vmbrasseur vmbrasseur added this to the MVP milestone Jul 29, 2014
@vmbrasseur vmbrasseur added the bug label Jul 29, 2014
@notbenh
Copy link

notbenh commented Jul 30, 2014

It seems that the link is included, this shuld be enough. That said I did look and there are a few places that have pre-converted markdown versions but they are all robot translations so the smartquotes are not translated so I didn't force something. If I get board and this is really needed I guess I can do this by hand to account for the correct display.

@vmbrasseur
Copy link
Member Author

The "correct" way to do it is to have both a link and the full text to the license (in case the link stops working for some reason).

I have some versions I can lift from other projects on which I've worked recently. I probably would have lifted them earlier, had I noticed I'd shortchanged the license file here in my own project. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants