Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cases will be ignore #17

Open
NE-SmallTown opened this issue Nov 20, 2019 · 3 comments
Open

Some cases will be ignore #17

NE-SmallTown opened this issue Nov 20, 2019 · 3 comments

Comments

@NE-SmallTown
Copy link

NE-SmallTown commented Nov 20, 2019

The safe resolve seems not accurate, because something like @babel/xxx will not be treated as external.

I find that your comment said there is another plugin which could do this(I haven't test it for now), but I think maybe this is not a good way, from my personal perspective we should put that into this repo because this is its own responsibility to do this.

@elado
Copy link

elado commented Nov 21, 2019

Try https://github.com/Septh/rollup-plugin-node-externals

@NE-SmallTown
Copy link
Author

@elado I tried but seems that still doesn't work, unlike this repo just ignore the @babel/xxx, the plugin you mentioned ignore all except peerDependencies

@PredokMiF
Copy link

rollup-plugin-node-externals worked for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants