Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config documentation clarification #100

Closed
shazoom opened this issue Jun 10, 2017 · 7 comments
Closed

Config documentation clarification #100

shazoom opened this issue Jun 10, 2017 · 7 comments

Comments

@shazoom
Copy link

shazoom commented Jun 10, 2017

The distinction between US and UK language is based on the Echo being used, I think. I have a UK google music account but a US Dot using US english (and I'm in Brunei.) This, basis for following different instructions (the language of the Echo) isn't very clear from the docs.

I followed instruction for the US configuration (with Heroku) which I expected to fail (because I have a UK google music account) but were so much simpler I thought it was worth a try. Slightly surprised to find it worked 😊

@digiltd
Copy link
Contributor

digiltd commented Jun 10, 2017

I think the current information is correct

This Skill was developed to only work on English (US) language devices.

(I maybe a bit biased as I wrote it 😄 )

Which is kinda what you are saying "The distinction between US and UK language is based on the Echo being used, I think."

Maybe you didn't spot it in the notes section?

@shazoom
Copy link
Author

shazoom commented Jun 10, 2017 via email

@digiltd
Copy link
Contributor

digiltd commented Jun 11, 2017

Thanks, but I can't the credit. All I did was update the docs and cobbled together the UK workaround. I will add the clarification, but steven will have to merge it

digiltd added a commit to digiltd/geemusic that referenced this issue Jun 12, 2017
@stevenleeg
Copy link
Owner

Just merged it in. Is there anything else that needs to get done here or is this issue good to close?

@shazoom
Copy link
Author

shazoom commented Jun 14, 2017

It looks good to me 😊

@domdomegg
Copy link

Over two months after merge, close this issue?

@shazoom
Copy link
Author

shazoom commented Aug 22, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants