Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccessToken missing id_toek in jsonSerialize #4

Closed
fanglingsu opened this issue Feb 3, 2017 · 2 comments
Closed

AccessToken missing id_toek in jsonSerialize #4

fanglingsu opened this issue Feb 3, 2017 · 2 comments

Comments

@fanglingsu
Copy link

I think it would be better to add the id_token also to the response of the jsonSerialize Method of the access Token. So the received, token containing the id token, could be stored in the session. Maybe you can add something like this to the AccessToken class:

public function jsonSerialize()
{
    $parameters = parent::jsonSerialize();
    if ($this->idToken) {
        $parameters['id_token'] = (string)$this->idToken;
    }

    return $parameters;
}
@steverhoades
Copy link
Owner

@fanglingsu This looks good. Can you provide a pull request?

@fanglingsu
Copy link
Author

I don't have much time, so you can put it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants