ENH: Add support for multiple rabbit hosts in con string #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Support constructing a connection string which contains multiple host endpoints. This avoids us going through an LB and matches the approach used by OpenStack more closely.
DavidFair
force-pushed
the
Connect_to_rabbit_hosts_directly
branch
from
ffb52b7
to
06bbfc8
Compare
meoflynn
previously approved these changes
Jul 2, 2024
anish-mudaraddi
requested changes
Jul 2, 2024
Builds a secondary strng for the debug output where we never place the password in, instead of replacing it later. This further lowers the chance of printing sensitive details if the replace didn't work
anish-mudaraddi
approved these changes
Jul 2, 2024
meoflynn
requested changes
Jul 2, 2024
meoflynn
previously approved these changes
Jul 2, 2024
…osts_directly Pull in update workflows to allow CI/CD jobs to finish in this PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #151 +/- ##
==========================================
- Coverage 97.23% 96.03% -1.20%
==========================================
Files 66 19 -47
Lines 2997 1211 -1786
==========================================
- Hits 2914 1163 -1751
+ Misses 83 48 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anish-mudaraddi
previously approved these changes
Jul 2, 2024
Specify a Rabbit host directly, since trying to connect to multiple hosts isn't working We'll address this in a future commit since the foundation is in place
anish-mudaraddi
approved these changes
Jul 2, 2024
meoflynn
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be connecting to the rabbit MQ hosts directly, this is currently preventing us from consuming messages as we previously went through a LB which is now unavailable
Support constructing a connection string which contains multiple host endpoints.
This avoids us going through an LB and matches the approach used by OpenStack more closely.
TBC Update host endpoint to point directly to our HV's in the chart
Update chart version to ensure the new app version is picked up