Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for intel devices? #95

Closed
ElliottKasoar opened this issue Mar 28, 2024 · 1 comment · Fixed by #208
Closed

Add option for intel devices? #95

ElliottKasoar opened this issue Mar 28, 2024 · 1 comment · Fixed by #208
Labels
enhancement New/improved feature or request

Comments

@ElliottKasoar
Copy link
Member

MACE seems to have added support for the "xpu" device (at least for training) via the intel_extension_for_pytorch package.

I imagine this could be useful for anyone using the new Intel PVCs via Dawn, and elsewhere.

We can certainly add xpu as a valid device type straightforwardly. I think everything else can be handled by the individual MLIP calculators, so that may be all that's required?
@ElliottKasoar ElliottKasoar added enhancement New/improved feature or request janus labels Mar 28, 2024
@alinelena
Copy link
Member

yap shall be added, also the config file got merged we shall check it.

@ElliottKasoar ElliottKasoar mentioned this issue Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New/improved feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix setting devices ElliottKasoar/janus-core
2 participants
@alinelena @ElliottKasoar