fix: xread fixes #1318
Merged
fix: xread fixes #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syntax for an XREAD command is ``` XREAD [COUNT count] [BLOCK milliseconds] STREAMS key [key ...] id [id ...] ``` Before this fix the implementation used ``` XREAD [COUNT count] [BLOCK milliseconds] STREAMS key id [key id...] ``` The new approach should be equally fast and provide the correct results. Also adjusted existing tests. Links: https://redis.io/commands/xread/
It needs to wait until the timeElapsed is greater or eq the defined blocking time. The test was enhanced to spot the issue and verify the fix worked. This uncovered another issue with the way found events are evaluated to always return even without any event received. This problem is also fixed by this commit.
ullumullu
force-pushed
the
bug/xread_fixes
branch
from
b5983f6
to
a93727c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of bugfixes for the XREAD command. Consult the individual commits for details.