Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatibility of upgrading to latest release 20220320 from release 20140107. #676

Closed
dushaniw opened this issue Mar 25, 2022 · 3 comments

Comments

@dushaniw
Copy link

dushaniw commented Mar 25, 2022

Hi,
We have been using JSON-java library version 20140107 so far (since 2014). Recently we discovered a vulnerability reported which is also mentioned in #654 (java.lang.StackOverflowError in org.json.JSONTokener.nextValue::JSONTokener.java:431 json-java). We noticed that this has been fixed in recent release 20220320.

As we have been using the 20140107 for so long, we want to know the following.

  1. Would upgrading to 20220320 will introduce us with backward incompatibility issues? Is there a way to make sure upgrading is backward compatible?
  2. We tried to find the code base of JSON-Java release 20140107 in the same git repo, but we couldnt. Where can we find the code base for 20140107 release tag?

@stleary Appreciate if we can get response for this as soon as possible.

@dushaniw dushaniw changed the title Backward compatibility of latest release with release 20140107. Backward compatibility of latest release comparing to release 20140107. Mar 25, 2022
@dushaniw dushaniw changed the title Backward compatibility of latest release comparing to release 20140107. Backward compatibility of upgrading to latest release from release 20140107. Mar 25, 2022
@dushaniw dushaniw changed the title Backward compatibility of upgrading to latest release from release 20140107. Backward compatibility of upgrading to latest release 20220320 from release 20140107. Mar 25, 2022
@stleary
Copy link
Owner

stleary commented Mar 25, 2022

@dushaniw Maintaining backward compatibility has been a priority since 2015, and before I got here, Douglas did not allow very many changes, either. I cannot guarantee there are no breaking changes, but let me know if you run into any issues and I will see if they can be mitigated. The 20140107 release predates my arrival, I am not sure how you could go about recovering the source other than decompiling the jar file.

@johnjaylward
Copy link
Contributor

From the repo, the best I could give you for that release is the approximate commit:
4d86b05

That commit is from Nov 2013, and there are no commits after that until April 2014. Seems very likely that all code in that commit is part of the 20140107 release.

https://github.com/stleary/JSON-java/commits/master?before=6f92a3ab4e425123c4b1ac2b8b65a7d9fb1d9bcb+886&branch=master

@dushaniw
Copy link
Author

Thank you @stleary and @johnjaylward.

@dushaniw dushaniw closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants