diff --git a/pkg/receive/handler_test.go b/pkg/receive/handler_test.go index 22105d8e86..091857e270 100644 --- a/pkg/receive/handler_test.go +++ b/pkg/receive/handler_test.go @@ -1298,7 +1298,7 @@ func Heap(dir string) (err error) { return err } - f, err := os.Create(filepath.Join(dir, "impr5-go1.16.3.pprof")) + f, err := os.Create(filepath.Join(dir, "errimpr1-go1.16.3.pprof")) if err != nil { return err } diff --git a/pkg/receive/hashring.go b/pkg/receive/hashring.go index b368bf30e7..8a72e0f96b 100644 --- a/pkg/receive/hashring.go +++ b/pkg/receive/hashring.go @@ -67,7 +67,6 @@ func (s simpleHashring) GetN(tenant string, ts *prompb.TimeSeries, n uint64) (st return "", &insufficientNodesError{have: uint64(len(s)), want: n + 1} } - // TODO(bwplotka): This might be not needed, double check. sort.Slice(ts.Labels, func(i, j int) bool { return ts.Labels[i].Name < ts.Labels[j].Name }) return s[(labelpb.HashWithPrefix(tenant, ts.Labels)+n)%uint64(len(s))], nil diff --git a/pkg/receive/writer.go b/pkg/receive/writer.go index 913da33029..07c53df322 100644 --- a/pkg/receive/writer.go +++ b/pkg/receive/writer.go @@ -81,33 +81,32 @@ func (r *Writer) Write(ctx context.Context, tenantID string, wreq *prompb.WriteR switch err { case storage.ErrOutOfOrderSample: numOutOfOrder++ - level.Debug(r.logger).Log("msg", "Out of order sample", "lset", lset.String(), "sample", s.String()) + level.Debug(r.logger).Log("msg", "Out of order sample", "lset", lset, "sample", s) case storage.ErrDuplicateSampleForTimestamp: numDuplicates++ - level.Debug(r.logger).Log("msg", "Duplicate sample for timestamp", "lset", lset.String(), "sample", s.String()) + level.Debug(r.logger).Log("msg", "Duplicate sample for timestamp", "lset", lset, "sample", s) case storage.ErrOutOfBounds: numOutOfBounds++ - level.Debug(r.logger).Log("msg", "Out of bounds metric", "lset", lset.String(), "sample", s.String()) + level.Debug(r.logger).Log("msg", "Out of bounds metric", "lset", lset, "sample", s) } } } if numOutOfOrder > 0 { - level.Warn(r.logger).Log("msg", "Error on ingesting out-of-order samples", "num_dropped", numOutOfOrder) - errs.Add(errors.Wrapf(storage.ErrOutOfOrderSample, "failed to non-fast add %d samples", numOutOfOrder)) + level.Warn(r.logger).Log("msg", "Error on ingesting out-of-order samples", "numDropped", numOutOfOrder) + errs.Add(errors.Wrapf(storage.ErrOutOfOrderSample, "add %d samples", numOutOfOrder)) } if numDuplicates > 0 { - level.Warn(r.logger).Log("msg", "Error on ingesting samples with different value but same timestamp", "num_dropped", numDuplicates) - errs.Add(errors.Wrapf(storage.ErrDuplicateSampleForTimestamp, "failed to non-fast add %d samples", numDuplicates)) + level.Warn(r.logger).Log("msg", "Error on ingesting samples with different value but same timestamp", "numDropped", numDuplicates) + errs.Add(errors.Wrapf(storage.ErrDuplicateSampleForTimestamp, "add %d samples", numDuplicates)) } if numOutOfBounds > 0 { - level.Warn(r.logger).Log("msg", "Error on ingesting samples that are too old or are too far into the future", "num_dropped", numOutOfBounds) - errs.Add(errors.Wrapf(storage.ErrOutOfBounds, "failed to non-fast add %d samples", numOutOfBounds)) + level.Warn(r.logger).Log("msg", "Error on ingesting samples that are too old or are too far into the future", "numDropped", numOutOfBounds) + errs.Add(errors.Wrapf(storage.ErrOutOfBounds, "add %d samples", numOutOfBounds)) } if err := app.Commit(); err != nil { errs.Add(errors.Wrap(err, "commit samples")) } - return errs.Err() }