Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proper source for errors involving empty $ref #1531

Merged
merged 2 commits into from
Mar 2, 2021
Merged

fix: proper source for errors involving empty $ref #1531

merged 2 commits into from
Mar 2, 2021

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Mar 2, 2021 •
edited
Loading

Fixes #1515
Complementary PR: stoplightio/json-ref-resolver#212

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip self-assigned this Mar 2, 2021
@P0lip P0lip added the t/bug Something isn't working label Mar 2, 2021
billiegoose
billiegoose approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@billiegoose billiegoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P0lip P0lip enabled auto-merge (squash) March 2, 2021 21:36
@P0lip P0lip merged commit f0f8165 into develop Mar 2, 2021
@P0lip P0lip deleted the fix/empty-source branch March 2, 2021 21:51
P0lip added a commit that referenced this pull request Mar 8, 2021
@P0lip
fix: proper source for errors involving empty $ref (#1531)
77128eb
This was referenced Mar 9, 2021
Merged
Closed
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billiegoose billiegoose billiegoose approved these changes

Assignees

@P0lip P0lip

Labels
t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing source in result object
2 participants
@P0lip @billiegoose