Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport read_quad optimization #27

Open
Gozala opened this issue Sep 12, 2023 · 0 comments
Open

Backport read_quad optimization #27

Gozala opened this issue Sep 12, 2023 · 0 comments

Comments

@Gozala
Copy link
Contributor

Gozala commented Sep 12, 2023

In the rust implementation I have optimized code such that we do not have to read out leaves only to combine pairs into nodes afterwards, which avoids bunch of memory copying

https://github.com/web3-storage/fr32-sha2-256-trunc254-padded-binary-tree-multihash/blob/98fe584ae5ae2c3790ec72c530aff5b36e2b1b92/src/hasher.rs#L143-L179

It would be a good idea to backport this logic here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant