Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blob-fetcher): use updated blob fetcher #124

Merged
merged 1 commit into from
Nov 1, 2024
Merged

feat(blob-fetcher): use updated blob fetcher #124

merged 1 commit into from
Nov 1, 2024

Conversation

hannahhoward
Copy link
Member

Goals

Read sharded dag indexes properly, even in the absense of location claims

Implementation

  • use update blob-fetcher
  • pass values to enable carpark fallback
  • add two tests to verify:
    • that normal index shard fetching works in the presence of location claims
    • that in the absense of location claims it can fill in the missing values.

@hannahhoward
feat(blob-fetcher): use updated blob fetcher
7bca2cc 
handle issues with not fetching blobs properly
alanshaw
alanshaw approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@hannahhoward hannahhoward merged commit 90bb605 into main Nov 1, 2024
1 check passed
@hannahhoward hannahhoward deleted the feat/use-updated-blob-fetcher branch November 1, 2024 16:59
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Merged
hannahhoward pushed a commit that referenced this pull request Nov 9, 2024
@github-actions
chore(main): release 2.21.0 (#117)
c4370d1 
🤖 I have created a release *beep* *boop*
---


##
[2.21.0](v2.20.2...v2.21.0)
(2024-11-06)


### Features

* **blob-fetcher:** use updated blob fetcher
([#124](#124))
([90bb605](90bb605))
* egress tracker middleware
([#120](#120))
([847829b](847829b))
* rate limiter + unit tests + readme
([#115](#115))
([7bc4c6d](7bc4c6d))


### Bug Fixes

* **test:** enable nodejs compat for miniflare
([#127](#127))
([0165521](0165521))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahhoward @alanshaw