feat: batch endpoint check items in parallel #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch to checking all the items in parallel, and let the platform decide the concurrency. Drops the unwarm time to check 1000 items from ~180s to ~10s Drops the warm time to check 100o items from ~50s to 5s ```sh ❯ time curl "http://127.0.0.1:8787/" --json @denylist.post.1000.json [] ________________________________________________________ Executed in 4.36 secs fish external ``` ...for obvious reason of not doing each one sequentially. License: MIT Signed-off-by: Oli Evans <[email protected]>
olizilla
commented
Jun 28, 2023
| @@ -35,7 +35,7 @@ routes = [ | |||
| { pattern = "denylist-staging.dag.haus/*", zone_id = "f2f8a5b1c557202c6e3d0ce0e98e4c8e" } | |||
| ] | |||
| kv_namespaces = [ | |||
| { binding = "DENYLIST", id = "f4eb0eca32e14e28b643604a82e00cb3" } | |||
| { binding = "DENYLIST", id = "f4eb0eca32e14e28b643604a82e00cb3", preview_id = "f4eb0eca32e14e28b643604a82e00cb3" } | |||
There was a problem hiding this comment.
this lets try out changes against the staging kv with
wrangler dev --remote --env staging
There was a problem hiding this comment.
oh nice, did not know this
olizilla
commented
Jun 28, 2023
Comment on lines
+11
to
+12
| const hash = await sha256.encode(uint8arrays.fromString(`${cid}/`)) | ||
| return uint8arrays.toString(hash, 'hex') |
There was a problem hiding this comment.
unrelated simplification that was bugging me
|
tested on staging cold ❯ time curl "https://denylist-staging.dag.haus/" --json @denylist.post.1000.json
[]
________________________________________________________
Executed in 30.55 secs fish externalwarm time curl "https://denylist-staging.dag.haus/" --json @denylist.post.1000.json
[]
________________________________________________________
Executed in 5.75 secs fish external |
vasco-santos
approved these changes
Jun 29, 2023
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to checking all the items in parallel, and let the platform decide the concurrency.
Drops the time to check 1000 items by an order of magnitude
...for obvious reason of not doing each one sequentially.
License: MIT