Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

denylist package #68

Closed
3 of 4 tasks
vasco-santos opened this issue Sep 13, 2022 · 1 comment · Fixed by #125 · May be fixed by #185
Closed
3 of 4 tasks

denylist package #68

vasco-santos opened this issue Sep 13, 2022 · 1 comment · Fixed by #125 · May be fixed by #185
Assignees
@jsdevel @e-schneid
Labels
kind/enhancement A net-new feature or improvement to an existing feature pi/malware-mitigation

Comments

@vasco-santos
Copy link
Contributor

vasco-santos commented Sep 13, 2022 •
edited by jsdevel
Loading

Motivation

Found an issue when a given worker does 2+ interactions with same worker binding during the same request. It weirdly reuses same Request instance (updated with new request), which consequently makes our logger/sentry not properly reporting the request.url + request.method (they are overwritten…). If we just clone the request to provide Logger and Sentry, then all follow up requests come with same first request details…

Plan

Create denylist package and integrate it:
@vasco-santos vasco-santos added kind/enhancement A net-new feature or improvement to an existing feature pi/malware-mitigation labels Sep 13, 2022
jsdevel added a commit that referenced this issue Sep 23, 2022
@jsdevel
feat: adding denylist package (closes #68)
2df282f
jsdevel added a commit that referenced this issue Sep 30, 2022
@jsdevel
feat: adding denylist package (closes #68)
a7c20ba
jsdevel added a commit that referenced this issue Sep 30, 2022
@jsdevel
feat: adding denylist package (closes #68)
f4a3081
jsdevel added a commit that referenced this issue Sep 30, 2022
@jsdevel
feat: adding denylist package (closes #68)
90c9008
jsdevel added a commit that referenced this issue Sep 30, 2022
@jsdevel
feat: adding denylist package (closes #68)
1454d91
jsdevel added a commit that referenced this issue Oct 6, 2022
@jsdevel
feat: adding denylist package (closes #68)
70051ef
jsdevel added a commit that referenced this issue Nov 16, 2022
@jsdevel
feat: adding denylist package (closes #68)
ef7c3ba
jsdevel added a commit that referenced this issue Nov 18, 2022
@jsdevel
Merge pull request #77 from web3-storage/feat-adding-denylist-package
637bf20 
feat: adding denylist package (closes #68)
@vasco-santos vasco-santos reopened this Nov 21, 2022
@vasco-santos
Copy link
Contributor Author

@jsdevel we still need to integrate this into edge-gateway package, as well as remove code from cid-verifier

@github-actions github-actions bot mentioned this issue Dec 9, 2022
Merged
vasco-santos pushed a commit that referenced this issue Dec 21, 2022
@github-actions
chore(main): release denylist 1.0.0 (#125)
2f323b5 
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2022-12-20)


### Features

* adding denylist package (closes
[#68](#68))
([ad93e85](ad93e85))
* using denylist from edge-gateway
([#126](#126))
([22c0123](22c0123))


### Bug Fixes

* denylist tests and logging
([82e3eaa](82e3eaa))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Sep 20, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsdevel jsdevel

@e-schneid e-schneid

Labels
kind/enhancement A net-new feature or improvement to an existing feature pi/malware-mitigation
Projects
None yet
Milestone
No milestone
3 participants
@jsdevel @vasco-santos @e-schneid