Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/allocate should have receipt as cause instead of blob/add task #122

Open
vasco-santos opened this issue Apr 18, 2024 · 5 comments
Open

Comments

@vasco-santos
Copy link
Contributor

See context: storacha/w3infra#353 (comment)

link to the signed receipt as opposed to invocation. In a way all our stores should simply be indexes over receipts because receipts are signed commitments from us, also they do link back to the corresponding invocation.

@vasco-santos
Copy link
Contributor Author

I believe the problem we currently would have to implement this is our lack of ability to have the link to the signed receipt at the point in time that allocate happens. But I may be missing something, what do you think @Gozala ?

@Gozala
Copy link
Collaborator

Gozala commented Apr 22, 2024

I believe the problem we currently would have to implement this is our lack of ability to have the link to the signed receipt at the point in time that allocate happens. But I may be missing something, what do you think @Gozala ?

Ah I suppose that is because ucanto takes care of creating them for us ? I guess we just need to allow returning receipt from the advanced handler in which case this will no longer be an issue.

@Gozala
Copy link
Collaborator

Gozala commented Apr 22, 2024

BTW I think this issue description is very confusing, my original comment was suggesting that listing blobs should return list of receipts, not that blob/allocate should have cause field linking to the blob/add receipt because that would introduce a cycle.

@vasco-santos
Copy link
Contributor Author

BTW I think this issue description is very confusing, my original comment was suggesting that listing blobs should return list of receipts, not that blob/allocate should have cause field linking to the blob/add receipt because that would introduce a cycle.

I think you are not correct on this. You also gave that feedback, which I also agree, but please have a look on the referenced comment with context on first message of the issue 😅

@Gozala
Copy link
Collaborator

Gozala commented May 7, 2024

Sorry I was not very clear with what I was talking about when I expressed that links should be to a receipts. I was trying to say that we should be storing blob/allocate receipts in the store as store is effectively an index over those receipts and I think you mistook it for me saying that we should link to blob/add receipts which would not be possible because it does not exist at the time of allocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants