-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: add services-core and react-services packages to encapsulate upload/access service configuration #156
Comments
Is it possible to hoist this into the w3up-client layer? |
half of it yep! per discussion this morning with @gobengo @alanshaw @hugomrdias @Gozala it sounds like the package that actually encapsulates the service details should be outside this repository entirely so that other services and libraries can all depend on it as well. we will still need to implement framework specific configuration components (ie, Providers in React, something else in other frameworks) and those should probably still be in their own package, worth leaving this issue open for that |
IMO we may not really need this. They'll just need to know whether they are trying to send invocations to |
oh that will definitely make this simpler - I thiiiink we'll still want a package that provides affordances for easily changing which service the w3ui components are using (ie, lets you override which DID the |
I started trying to write a
ServicesContext
that can optionally be configured to point w3ui components at staging, production or another branch. I realized this probably needs to be done in its own set of packages (one core, and one for each framework we support).I'll probably tweak some typing in this process (ie, split the two slightly different things currently called ServiceConfig into UploadServiceConfig and AccessServiceConfig)
@alanshaw just want to make sure you don't have something in process around this - happy to expand a bit more on what I'm thinking if that'd be helpful
The text was updated successfully, but these errors were encountered: