-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formats/fs: Set NTFS to be formattable #536
Conversation
During running the test suite I found that while MKNTFS_APP is available, the tests for NTFS are skipped because it's not marked to be formattable. Signed-off-by: aszlig <[email protected]>
Even though the ntfs3g utilities are available inside our test environment, the format didn't get advertised as formattable because the _formattable attribute wasn't set to True. Submitted upstream at: storaged-project/blivet#536 Signed-off-by: aszlig <[email protected]>
Jenkins, ok to test. |
The test failures are unrelated to these changes. @dwlehman: I think I remember some discussion about this, is there some reason for not having NTFS formattable? |
Jenkins, test this, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Since we have tasks now, it shouldn't be a problem if the NTFS tools are not available.
Even though the ntfs3g utilities are available inside our test environment, the format didn't get advertised as formattable because the _formattable attribute wasn't set to True. Submitted upstream at: storaged-project/blivet#536 Signed-off-by: aszlig <[email protected]>
During running the test suite I found that while
MKNTFS_APP
is available, the tests for NTFS are skipped because it's not marked to be formattable.