Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: manager-build tsconfig jsx setting #20968

Closed
jgodi opened this issue Feb 6, 2023 · 0 comments · Fixed by #28541
Closed

[Bug]: manager-build tsconfig jsx setting #20968

jgodi opened this issue Feb 6, 2023 · 0 comments · Fixed by #28541

Comments

@jgodi
Copy link

jgodi commented Feb 6, 2023

Describe the bug

In the tsconfig that is used to build/compile the custom addons there is the following tsconfig that is used:

https://github.com/storybookjs/storybook/blob/187b02b0ce8797495d17ce93626c160e4fc3af60/code/lib/builder-manager/templates/addon.tsconfig.json

{
  "compilerOptions": {
    "jsx": "react",
    "jsxImportSource": "react"
  }
}

I am building out a custom addon that uses our custom components within our design system and I run into issues around React is not defined because we use react-jsx internally and we have alias to use the src code vs. the compiled code. I would rather build out using our design system for these addons vs. using the storybook components to make it look and feel like the rest of the app.

Could this jsx be set to react-jsx instead?

To Reproduce

No repro library, but when I override the `jsx` to be `react-jsx`, my local is unblocked.

System

7.0.0-beta.43 (latest)

Additional context

No response

@jgodi jgodi changed the title [Bug]: [Bug]: manager-build tsconfig jsx setting Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant