-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Storybook 7.0.0 to 7.1.0 - TypeScript warnings for @storybook/angular framework #21696
Comments
I'm on 7.0.8 and I'm facing this only when I set
Letting the default |
I'm using 7.0.11 for web components and I also face the same issue when setting storyStorev7 to false which I'm having to do because of component rendering issues. ./.storybook/preview.js-generated-config-entry.js 15:15-41 |
I am not positive, but this may be related to another issue I have been looking into. #22542 Does anyone have a repro of this issue, to see if it is the same as the one I am debugging and may provide more information on where to look? My issue only throws at runtime and it is with a non-storybook dependency, but it is also an Looking at some of the |
Not a minimal repro but easy to reproduce... git clone https://github.com/nstuyvesant/carbon-charts.git
cd carbon-charts
git checkout pr-1544
git pull
yarn install
yarn build
cd packages/angular
yarn build:demo Actually the broader |
By the way, our Angular package is 16.0.1. |
7.0.27 still has this error as well |
Still an issue with 7.1.0. |
Still the same with 7.3.1 |
@KarineBrandelli using |
@baileyandy that's the thing, my stories are already migrated. It seems a problem in the this is when |
I can't reproduce it in the latest version of Storybook v8. Can someone provide a reproduction with the latest version of Storybook? https://storybook.new |
Hi there! Thank you for opening this issue, but it has been marked as |
We went a different direction and no longer use Storybook. Perhaps someone else can provide a repro. |
I'm afraid we need to close this issue for now, since we can't take any action without the requested reproduction or additional information. But please don't hesitate to open a new issue if the problem persists – we're always happy to help. Thanks so much for your understanding. |
Describe the bug
I am using Storybook 7.0.0-rc.4 with Angular 14.2. In the tsconfig.json for Storybook, I forgot to set compilerOptions.skipLibCheck to false and it reported these warnings...
The build proceeded without problems but I thought I'd report this.
To Reproduce
No response
System
Environment Info: System: OS: macOS 13.2.1 CPU: (10) arm64 Apple M1 Pro Binaries: Node: 18.15.0 - /opt/homebrew/bin/node Yarn: 3.5.0 - /opt/homebrew/bin/yarn npm: 9.6.2 - /opt/homebrew/bin/npm Browsers: Chrome: 111.0.5563.64 Firefox: 111.0 Safari: 16.3 npmPackages: @storybook/angular: ^7.0.0-0 => 7.0.0-rc.4
Additional context
No response
The text was updated successfully, but these errors were encountered: