You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently ask maintainers to apply ci:merged or ci:daily labels on pull request in order to run the respective CI jobs to test the PR against "all" or "many" sandboxes prior to merging. However, this requirement currently only exists as a checkbox on the PR template, and is not enforced programmatically. This makes it easy to miss, and as a results, PRs that should have been tested with the more rigorous CI jobs have gotten merged without them.
Proposed solution
Add ci:normal label which explicitly states that this PR does not need to be tested against many sandboxes
Modify danger js to make one of the three ci labels mandatory
Document (can be brief) what each of these labels mean so non-core maintainers can also know which label to apply to their own PR
The text was updated successfully, but these errors were encountered:
We currently ask maintainers to apply
ci:merged
orci:daily
labels on pull request in order to run the respective CI jobs to test the PR against "all" or "many" sandboxes prior to merging. However, this requirement currently only exists as a checkbox on the PR template, and is not enforced programmatically. This makes it easy to miss, and as a results, PRs that should have been tested with the more rigorous CI jobs have gotten merged without them.Proposed solution
ci:normal
label which explicitly states that this PR does not need to be tested against many sandboxesThe text was updated successfully, but these errors were encountered: