Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PR CI labels #23278

Closed
3 tasks
vanessayuenn opened this issue Jul 3, 2023 · 0 comments · Fixed by #23335
Closed
3 tasks

Improve PR CI labels #23278

vanessayuenn opened this issue Jul 3, 2023 · 0 comments · Fixed by #23335
Assignees
@valentinpalkovic
Labels
build Internal-facing build tooling & test updates documentation

Comments

@vanessayuenn
Copy link
Contributor

We currently ask maintainers to apply ci:merged or ci:daily labels on pull request in order to run the respective CI jobs to test the PR against "all" or "many" sandboxes prior to merging. However, this requirement currently only exists as a checkbox on the PR template, and is not enforced programmatically. This makes it easy to miss, and as a results, PRs that should have been tested with the more rigorous CI jobs have gotten merged without them.

Proposed solution

  • Add ci:normal label which explicitly states that this PR does not need to be tested against many sandboxes
  • Modify danger js to make one of the three ci labels mandatory
  • Document (can be brief) what each of these labels mean so non-core maintainers can also know which label to apply to their own PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinpalkovic valentinpalkovic

Labels
build Internal-facing build tooling & test updates documentation
Projects
Core Team Projects
Archived in project
Learning Team
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: Introduce ci:normal label storybookjs/storybook
2 participants
@valentinpalkovic @vanessayuenn