You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When search is focused but there is no query, we show "recently opened" stories in the sidebar.
The recently open story IDs are stored in localStorage, meaning that they can correspond to any Storybook running on the port. So to avoid problems, we filter those story IDs down to stories that actually exist in the currently open Storybook.
For some reason, the list of stories that we filter by, is in turn filtered down by the selected tags. So if you have play-fn selected but have not recently viewed any play-fn stories, the list will be empty and the sidebar will be blank. Unfortunately, this state is pretty easy to hit.
This seems like a bug because we should be checking against ALL stories in the current Storybook and not the list filtered by play-fn. If we make this change, it means that it's possible to navigate to a recently viewed story that is NOT showed in the sidebar.
As a related fix, we could also make it so that the currently selected story is ALWAYS shown in the sidebar even if it doesn't match the current set of filters. It could disappear from the sidebar as soon as the user navigates away from the story.
Reproduction link
N/A
Reproduction steps
No response
System
any
Additional context
No response
The text was updated successfully, but these errors were encountered:
Describe the bug
When search is focused but there is no query, we show "recently opened" stories in the sidebar.
The recently open story IDs are stored in localStorage, meaning that they can correspond to any Storybook running on the port. So to avoid problems, we filter those story IDs down to stories that actually exist in the currently open Storybook.
For some reason, the list of stories that we filter by, is in turn filtered down by the selected tags. So if you have
play-fn
selected but have not recently viewed anyplay-fn
stories, the list will be empty and the sidebar will be blank. Unfortunately, this state is pretty easy to hit.This seems like a bug because we should be checking against ALL stories in the current Storybook and not the list filtered by
play-fn
. If we make this change, it means that it's possible to navigate to a recently viewed story that is NOT showed in the sidebar.As a related fix, we could also make it so that the currently selected story is ALWAYS shown in the sidebar even if it doesn't match the current set of filters. It could disappear from the sidebar as soon as the user navigates away from the story.
Reproduction link
N/A
Reproduction steps
No response
System
any
Additional context
No response
The text was updated successfully, but these errors were encountered: