Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test progress denominator in Testing Module #29541

Open
Tracked by #29529
JReinhold opened this issue Nov 5, 2024 · 0 comments
Open
Tracked by #29529

Improve test progress denominator in Testing Module #29541

JReinhold opened this issue Nov 5, 2024 · 0 comments
Assignees

Comments

@JReinhold
Copy link
Contributor

JReinhold commented Nov 5, 2024

The current progress indicator in the Testing Module uses Vitest’s completion status X / Y, where the denominator steadily increases as the test run completes. Vitest has to do it this way because it cannot statically analyze all the test files.

But CSF is statically analyzable and Storybook knows exactly how many tests are going to be run. So we should be able to provide an accurate numerator for the run.

This should both work when testing all stories, and with focused tests, and we need to be mindful of the 'test' tag on stories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants