Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Support] Storybook + Angular 6 multiple apps (nrwl/nx) #3868

Closed
jogelin opened this issue Jul 11, 2018 · 5 comments
Closed

[Support] Storybook + Angular 6 multiple apps (nrwl/nx) #3868

jogelin opened this issue Jul 11, 2018 · 5 comments

Comments

@jogelin
Copy link

jogelin commented Jul 11, 2018

Bug or support request summary

I would like to setup storybook in my monorepo to be able to develop and tests shared components across all applications.

I have an issue concerning the import of the styles because storybook is using the property projects[0].root to resolve the paths of all styles from projects[0].architect.build.styles but my styles are also specifying the full path. So I see some errors like:

ERROR in multi ./apps/appName/libs/core/theme.scss ./apps/appName/apps/appName/src/styles.scss
Module not found: Error: Can't resolve 'C:\Users\user\dev\projects\frontend\monorepo\apps\appName\apps\crt\src\styles.scss' in 'C:\Users\user\dev\projects\frontend\monorepo'
 @ multi ./apps/appName/libs/core/theme.scss ./apps/appName/apps/appName/src/styles.scss +1

and my angular.json contain

...
"projects": {
    "appName": {
      "root": "apps/appName/",
      "sourceRoot": "apps/appName/src",
      ....
      "architect": {
        "build": {
            ...
            "styles": [
              "libs/core/theme.scss",
              "apps/appName/src/styles.scss"
            ],
...

Dependencies

  • @angular/*: 6.0.7
  • @storybook/*: 4.0.0-alpha.13
@igor-dv
Copy link
Member

igor-dv commented Jul 12, 2018

I think @rhalff was able to work arround this.

@headonkeyboard
Copy link

I've reported the same problem here : #3864

@stale
Copy link

stale bot commented Aug 3, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Aug 3, 2018
@headonkeyboard
Copy link

Does anyone managed to get it work ?

@stale stale bot removed the inactive label Aug 9, 2018
@igor-dv
Copy link
Member

igor-dv commented Aug 23, 2018

I will close this one in favor of #3864, also @marshallmick007 PRed a fix.

@jogelin, the angular builder is still relevant IMO.

@igor-dv igor-dv closed this as completed Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants