Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static version of Storybook doesn't like Safari #443

Closed
arunoda opened this issue Sep 9, 2016 · 3 comments · Fixed by storybook-eol/storybook-database-local#4
Closed

Comments

@arunoda
Copy link
Member

arunoda commented Sep 9, 2016

This is only the static build. Here's how to reproduce:

create-react-app demo
cd demo
getstorybook -f
npm run build-storybook
cd storybook-static
python -m SimpleHTTPServer 8010

Then visit http://localhost:8010 on safari and you'll see this:

screen shot 2016-09-09 at 2 21 38 pm

Could you guys have a look at this?
cc @mnmtanish @roonyh

@arunoda
Copy link
Member Author

arunoda commented Sep 9, 2016

Let's close this with a PR to this repo.
Anyway, do we need to update any package.json values?

@arunoda arunoda reopened this Sep 9, 2016
@thani-sh
Copy link
Contributor

thani-sh commented Sep 9, 2016

It's a patch release and It should work fine on fresh npm installs. Anyways, opened a pull-request here #444 which updates the package.json file.

@arunoda
Copy link
Member Author

arunoda commented Sep 9, 2016

Deployed a release.

@arunoda arunoda closed this as completed Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants