Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for testing storybook breaks on each code commit #547

Closed
mcreations opened this issue Oct 14, 2016 · 4 comments
Closed

Support for testing storybook breaks on each code commit #547

mcreations opened this issue Oct 14, 2016 · 4 comments

Comments

@mcreations
Copy link

Hi,
We heavily use React storybook for building React components in our project. There are multiple teams working on the project. We build stateless components and use props to pass values to the components. One of the main issues we face is that there are unintentional storybook breaks when one team changes data structures without changing the storybook tests. It would be better if we can add a pre-commit hook where we can test whether there are any storybook breaks before any commit.
We tried out storybook snapshots but it didn't serve our purpose. Any future ideas to implement a feature or addon for this or is there a method already to do this?
Thanks

@evgenykochetkov
Copy link
Contributor

Hi! I encountered a similar problem and would like to know what kind of solution you came up with.
Is specifications addon a good fit for this?

@tmeasday
Copy link
Member

@mcreations -- can I ask for more information? What is the issue with storyshots?

@tmeasday
Copy link
Member

Is this problem solved by #1034?

@mcreations
Copy link
Author

@tmeasday, Thanks for this solution. This seems to be what I was looking for. Let me try this out and get back to you if I come across any issues. Thanks again for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants