Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport addon has unnecessary scrollbar when dimension is set to 100% #6536

Closed
mtlewis opened this issue Apr 16, 2019 · 2 comments
Closed

Comments

@mtlewis
Copy link

mtlewis commented Apr 16, 2019

When one of the dimensions of the viewport is set to 100%, the additional margin added around the iframe causes an unnecessary scrollbar. Since the height is a percentage, it doesn't seem to make sense to force the content to be exactly 100% of the height of the storybook preview area - instead, it should probably take the extra margin into account.

To Reproduce
Steps to reproduce the behavior:

  1. Configure the viewport addon with a viewport with either width or height set to 100%
  2. Choose that viewport
  3. Observe that the viewport is slightly bigger than the available space.

Expected behavior
Viewport size is reduced slightly to avoid the unnecessary scrollbar. Note that this should probably do the right thing even if the viewport is close to 100%.

Screenshots
Current Behaviour:
Screenshot 2019-04-16 at 11 12 55

Proposed Behaviour
Screenshot 2019-04-16 at 11 13 22

@stale
Copy link

stale bot commented May 7, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 7, 2019
@stale
Copy link

stale bot commented Jun 6, 2019

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Jun 6, 2019
This was referenced Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants