Addons: avoid mixing manager and preview code together #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
added
bug
addon: actions
react-native
addon: events
addon: links
patch:yes
Codecov Report
@@ Coverage Diff @@
## master #3068 +/- ##
=========================================
- Coverage 36.78% 35.6% -1.19%
=========================================
Files 420 420
Lines 9873 9889 +16
Branches 831 827 -4
=========================================
- Hits 3632 3521 -111
- Misses 5788 5893 +105
- Partials 453 475 +22
Continue to review full report at Codecov.
|
igor-dv
approved these changes
Feb 24, 2018
Hypnosphi
added
patch:done
Hypnosphi
added a commit
that referenced
this pull request
Mar 6, 2018
…view Addons: avoid mixing manager and preview code together # Conflicts: # addons/storysource/register.js # addons/storysource/src/index.js
Hypnosphi
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2275 accidentally broke React Native. The problem is that glamorous contains browser-specific code, and this line makes it leak into RN: https://github.com/storybooks/storybook/blob/master/addons/actions/src/index.js#L6
What I did
Ensured that manager and preview code is separated in all existing addons